Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Clarify error when discovery source is invalid #3134

Merged
merged 1 commit into from
Aug 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/v1/cli/command/core/discovery_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,10 @@ func createDiscoverySource(dsType, dsName, uri string) (configv1alpha1.PluginDis
pluginDiscoverySource.Local = createLocalDiscoverySource(dsName, uri)
case common.DiscoveryTypeOCI:
pluginDiscoverySource.OCI = createOCIDiscoverySource(dsName, uri)
default:
case common.DiscoveryTypeGCP, common.DiscoveryTypeKubernetes, common.DiscoveryTypeREST:
return pluginDiscoverySource, errors.Errorf("discovery source type '%s' is not yet supported", dsType)
default:
return pluginDiscoverySource, errors.Errorf("unknown discovery source type '%s'", dsType)
}
return pluginDiscoverySource, nil
}
Expand Down
20 changes: 20 additions & 0 deletions pkg/v1/cli/command/core/discovery_source_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,26 @@ func Test_createDiscoverySource(t *testing.T) {
assert.NotNil(pd.OCI)
assert.Equal(pd.OCI.Name, "fake-oci-discovery-name")
assert.Equal(pd.OCI.Image, "test.registry.com/test-image:v1.0.0")

// When discovery source is gcp
_, err = createDiscoverySource("gcp", "fake-discovery-name", "fake/path")
assert.NotNil(err)
assert.Contains(err.Error(), "not yet supported")

// When discovery source is kubernetes
_, err = createDiscoverySource("kubernetes", "fake-discovery-name", "fake/path")
assert.NotNil(err)
assert.Contains(err.Error(), "not yet supported")

// When discovery source is rest
_, err = createDiscoverySource("rest", "fake-discovery-name", "fake/path")
assert.NotNil(err)
assert.Contains(err.Error(), "not yet supported")

// When discovery source is an unknown value
_, err = createDiscoverySource("unexpectedValue", "fake-discovery-name", "fake/path")
assert.NotNil(err)
assert.Contains(err.Error(), "unknown discovery source type 'unexpectedValue'")
}

func Test_addDiscoverySource(t *testing.T) {
Expand Down