This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This is kind of a follow-up of the refactoring of #3201.
The PR simply copies
pkg/v1/buildinfo/buildvar.go
to a newcli/runtime/buildinfo
package.This will allow plugins to get access to
buildinfo.Version
,buildinfo.SHA
andbuildinfo.Date
without having to import Framework.The PR also updates the
Makefile.tmpl
template to inject those values and themain.go.tmpl
to use this mechanism for new plugins.Which issue(s) this PR fixes
Fixes #3230
Describe testing done for PR
Created a new plugin and built it and verified that Version and SHA were injected automatically:
Release note
Additional information
We would need some doc to teach this to plugin developers. I can add it once #3259 is merged.