Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Azure cc test #3282

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Azure cc test #3282

merged 1 commit into from
Nov 1, 2022

Conversation

wjun
Copy link
Contributor

@wjun wjun commented Sep 8, 2022 •
edited
Loading

What this PR does / why we need it

Make azure cc dev plan creation work

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Additional information

Special notes for your reviewer

@wjun wjun requested review from a team as code owners September 8, 2022 04:40
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Hi @wjun! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Framework better.

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3282/20220908044817/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Sep 8, 2022 •
edited
Loading

Codecov Report

Merging #3282 (9363ddb) into main (395ef34) will decrease coverage by 0.90%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #3282      +/-   ##
==========================================
- Coverage   46.65%   45.74%   -0.91%     
==========================================
  Files         400      425      +25     
  Lines       39722    41282    +1560     
==========================================
+ Hits        18531    18884     +353     
- Misses      19498    20687    +1189     
- Partials     1693     1711      +18
Impacted Files Coverage Δ
tkg/client/init.go 0.00% <0.00%> (ø)
tkg/client/machine_deployment.go 61.86% <ø> (ø)
tkg/client/upgrade_cluster.go 44.62% <66.66%> (ø)
tkg/clusterclient/clusterclient.go 49.34% <85.71%> (ø)
cli/runtime/plugin/info.go 82.35% <100.00%> (+5.42%) ⬆️
...oller-manager/controllers/v3_cascade_controller.go 56.19% <0.00%> (-17.15%) ⬇️
packageclients/pkg/packageclient/package_update.go 83.57% <0.00%> (-1.43%) ⬇️
cmd/cli/plugin/cluster/delete_node_pool.go 16.66% <0.00%> (ø)
...in/cluster/set_machinehealthcheck_control_plane.go 21.21% <0.00%> (ø)
...cluster/delete_machinehealthcheck_control_plane.go 16.66% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wjun wjun force-pushed the topic/wjun/azure-cc branch from 4bcf342 to 00908cc Compare September 8, 2022 12:05
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3282/20220908121422/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@wjun wjun force-pushed the topic/wjun/azure-cc branch from 00908cc to 59bdeef Compare September 9, 2022 03:23
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3282/20220909033145/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@wjun wjun force-pushed the topic/wjun/azure-cc branch from 59bdeef to 08101e9 Compare September 9, 2022 03:54
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3282/20220909040244/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@wjun wjun force-pushed the topic/wjun/azure-cc branch from 08101e9 to 06de4b2 Compare September 16, 2022 08:27
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3282/20220916083658/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@wjun wjun force-pushed the topic/wjun/azure-cc branch from 06de4b2 to c6cfd7a Compare September 26, 2022 08:11
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3282/20220926082146/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@wjun wjun force-pushed the topic/wjun/azure-cc branch from c6cfd7a to 02eb9d4 Compare October 12, 2022 02:15
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3282/20221012022408/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@wjun wjun force-pushed the topic/wjun/azure-cc branch from 02eb9d4 to f184c87 Compare October 20, 2022 09:39
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3282/20221020094823/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@wjun wjun force-pushed the topic/wjun/azure-cc branch from f184c87 to 6e7bb99 Compare October 24, 2022 01:51
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3282/20221024015725/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@wjun wjun force-pushed the topic/wjun/azure-cc branch from 6e7bb99 to 6d68b3b Compare October 24, 2022 12:08
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3282/20221024121525/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@wjun wjun force-pushed the topic/wjun/azure-cc branch from 6d68b3b to b00becb Compare October 24, 2022 12:47
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3282/20221024125424/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@wjun wjun force-pushed the topic/wjun/azure-cc branch from b00becb to e840c7b Compare October 24, 2022 14:06
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3282/20221024141428/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@wjun wjun force-pushed the topic/wjun/azure-cc branch from e840c7b to b8f66bb Compare October 31, 2022 10:39
@wjun wjun force-pushed the topic/wjun/azure-cc branch from b8f66bb to 9363ddb Compare November 1, 2022 01:56
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3282/20221101020700/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

ydp
ydp reviewed Nov 1, 2022
View reviewed changes
packages/tkg-clusterclass-azure/bundle/config/upstream/base.yaml
subnets:
- name: ${AZURE_CONTROL_PLANE_SUBNET_NAME}
- name: #@ data.values.AZURE_CONTROL_PLANE_SUBNET_NAME
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jun, just want to learn the code, what's the difference between ${var} and #@ data.value.var ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${var} is deprecated and should not be used in ClusterClass because ytt cli can not interpolate it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ${var} will not be replaced in the package until cc topology controller processes it, while data.value.var will be replaced with value when the package is installed. ${var} is blocked by azureclustertemplate admission controller which has some subnet name regex check not allowing $ and {}, For this case, we must use data.values.var format. Ideally, we should remove ${var} from all cc related yamls.

@DanielXiao DanielXiao added the ok-to-merge PRs should be labelled with this before merging label Nov 1, 2022
@wjun wjun merged commit c710476 into main Nov 1, 2022
@wjun wjun deleted the topic/wjun/azure-cc branch November 1, 2022 09:20
m1zzx2 pushed a commit that referenced this pull request Nov 1, 2022
@wjun
Azure cc test (#3282)
b916684 
Make azure cc dev plan creation work.
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@DanielXiao DanielXiao DanielXiao approved these changes

@ydp ydp ydp approved these changes

@xiaoping8385 xiaoping8385 xiaoping8385 approved these changes

Assignees
No one assigned
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wjun @DanielXiao @ydp @xiaoping8385 @vmwclabot