Use CAPV util function to retrieve VSphere cluster credentials.

[HanFa]

What this PR does / why we need it

To retrieve the credential from a VSphereCluster, instead of just getting it from the associated secret object, we use CAPV util function to cover the case of multi-tenancy.

Which issue(s) this PR fixes

Fixes #

#3392

Describe testing done for PR

Addon Controller integration test with KUBEBUILDER_ASSETS=/Users/hanfa/workspace/tanzu-framework-HanFa/hack/tools/bin/kubebuilder/bin go test ./controllers -v

Manually testing for non-paravirt uTKG

Release note

package-based-lcm: Use CAPV util function to retrieve VSphere cluster credentials.

Additional information

Special notes for your reviewer

[codecov]

Codecov Report

Merging #3391 (f783cbc) into main (142aa6f) will increase coverage by 0.85%.
The diff coverage is 90.05%.

@@            Coverage Diff             @@
##             main    #3391      +/-   ##
==========================================
+ Coverage   53.12%   53.97%   +0.85%     
==========================================
  Files         103       91      -12     
  Lines       10419    10006     -413     
==========================================
- Hits         5535     5401     -134     
+ Misses       4429     4171     -258     
+ Partials      455      434      -21     

Impacted Files	Coverage Δ
...sphere-template-resolver/templateresolver/types.go	42.10% <42.10%> (ø)
...ter/vsphere-template-resolver/template/resolver.go	89.91% <89.91%> (ø)
...emplate-resolver/templateresolver/resolver_impl.go	99.02% <99.02%> (ø)
...re-template-resolver/templateresolver/interface.go	100.00% <100.00%> (ø)
addons/controllers/clusterbootstrap_controller.go	64.50% <0.00%> (-0.05%)	⬇️
capabilities/client/pkg/discovery/cluster_gvr.go
...apabilities/client/pkg/discovery/cluster_object.go
...apabilities/client/pkg/discovery/cluster_schema.go
capabilities/client/pkg/discovery/discovery.go
capabilities/client/pkg/discovery/fake.go
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[lubronzhan]

lgtm

[randomvariable]

Split the testutil changes into a separate commit, otherwise lgtm

[maralavi]

@HanFa Will a resource of kind VSphereClusterIdentity or an identityRef on a VsphereCluster exist for sure in a cluster? How credentials would be fetched if they don’t?

[HanFa]

Will a resource of kind VSphereClusterIdentity or an identityRef on a VsphereCluster exist for sure in a cluster? How credentials would be fetched if they don’t?

Hi @maralavi , not necessarily. If the VSphereClusterIdentity doesn't exist, the secretRef type should be Secret instead, the controller shall grab the credentials from the ref-ed secret object.

[maralavi]

Will a resource of kind VSphereClusterIdentity or an identityRef on a VsphereCluster exist for sure in a cluster? How credentials would be fetched if they don’t?

Hi @maralavi , not necessarily. If the VSphereClusterIdentity doesn't exist, the secretRef type should be Secret instead, the controller shall grab the credentials from the ref-ed secret object.

Thanks for the clarification @HanFa . Can we expect that capvidentity.GetCredentials() take care of that case too? (I ask as now getSecret() is removed?)

[HanFa]

Will a resource of kind VSphereClusterIdentity or an identityRef on a VsphereCluster exist for sure in a cluster? How credentials would be fetched if they don’t?

Hi @maralavi , not necessarily. If the VSphereClusterIdentity doesn't exist, the secretRef type should be Secret instead, the controller shall grab the credentials from the ref-ed secret object.

Thanks for the clarification @HanFa . Can we expect that capvidentity.GetCredentials() take care of that case too? (I ask as now getSecret() is removed?)

yes, that's exactly the case

https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/9492c4bb01f03a0cec534311ed1d61515e94eddf/pkg/identity/identity.go#L53

[maralavi]

Changes look good to me, thanks for the changes. Lets wait for the test pipeline pass before merging.