Add aws ebs csi api and controller for classy cluster #3424

jeffwubj · 2022-09-20T02:31:14Z

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #3399
Add Classy Cluster support for AWS EBS CSI driver:

Introduce a controller to reconcile AwsEbsCSIConfig
Change CC pipeline to use tanzu version 0.27 -> use 1.7.0 BoM which contains CC based EBS CSI Driver Package
Stable CC pipelines with 1.7.0 BoM ( however legacy pipelines are not stable, given it happened in other PRs, should be not relevant )
Add UT for new controller
Unblock downstream BoM modifications ( bolt build will depend on config files in this PR )

Describe testing done for PR

Use new compability file, could install aws ebs csi driver
Run pipeline locally, could spin up CC cluster and aws ebs csi driver is installed

Release note

Support AWS EBS CSI Driver in Cluster Class

Additional information

Special notes for your reviewer

github-actions · 2022-09-20T02:45:48Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20220920024546/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

codecov · 2022-09-20T03:27:57Z

Codecov Report

Merging #3424 (17d5b2a) into main (43bfbb3) will decrease coverage by 0.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3424      +/-   ##
==========================================
- Coverage   46.20%   45.30%   -0.91%     
==========================================
  Files         400      425      +25     
  Lines       39624    41180    +1556     
==========================================
+ Hits        18310    18657     +347     
- Misses      19626    20816    +1190     
- Partials     1688     1707      +19

Impacted Files	Coverage Δ
...oller-manager/controllers/v3_cascade_controller.go	`61.90% <0.00%> (-11.43%)`	⬇️
cmd/cli/plugin/cluster/set_machinehealthcheck.go	`23.33% <0.00%> (ø)`
...cluster/delete_machinehealthcheck_control_plane.go	`16.66% <0.00%> (ø)`
cmd/cli/plugin/cluster/scale.go	`17.85% <0.00%> (ø)`
...in/cluster/get_machinehealthcheck_control_plane.go	`11.11% <0.00%> (ø)`
cmd/cli/plugin/cluster/osimage.go	`100.00% <0.00%> (ø)`
cmd/cli/plugin/cluster/kubeconfig_get.go	`8.82% <0.00%> (ø)`
cmd/cli/plugin/cluster/delete_node_pool.go	`16.66% <0.00%> (ø)`
cmd/cli/plugin/cluster/list.go	`9.52% <0.00%> (ø)`
cmd/cli/plugin/cluster/upgrade.go	`58.50% <0.00%> (ø)`
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-09-20T09:37:21Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20220920093719/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-09-21T11:15:20Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20220921111517/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-09-22T03:37:37Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20220922033735/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-09-22T03:40:31Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20220922034030/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-09-22T09:52:41Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20220922095239/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-09-22T11:12:13Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20220922111211/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-09-24T01:30:31Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20220924013029/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-09-25T12:51:48Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20220925125146/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-09-25T12:54:22Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20220925125419/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-09-25T14:48:08Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20220925144805/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-09-26T04:22:55Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20220926042253/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

addons/controllers/awsebscsi/awsescsiconfig_utils.go

github-actions · 2022-09-30T11:06:11Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20220930110609/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

randomvariable · 2022-10-05T16:39:09Z

Looks fine from an AWS perspective

github-actions · 2022-10-10T01:25:34Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20221010012531/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-10-10T01:27:53Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20221010012751/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

DanielXiao · 2022-10-10T10:47:28Z

addons/controllers/awsebscsi/awsebscsiconfig_controller.go

+	csiCfg *csiv1alpha1.AwsEbsCSIConfig,
+	cluster *clusterapiv1beta1.Cluster) (result ctrl.Result, retErr error) {
+
+	logger := log.FromContext(ctx)


To get the logger from a context, NewContext(ctx context.Context, logger Logger) should be called beforehand.

wjun

LGTM

github-actions · 2022-10-14T04:09:17Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20221014040914/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-10-14T13:07:29Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20221014130727/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-10-14T15:38:39Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20221014153837/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

jeffwubj · 2022-10-15T02:46:41Z

//usebom:sandbox/v1.7.0-zshippable/429942865385264379/tkg-compatibility:v12

github-actions · 2022-10-19T02:25:26Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3424/20221019022524/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

* Add aws ebs csi api and controller for classy cluster * CI & UT & Related codes fix * tests * address review comments * update e2e after rebase

jeffwubj requested review from a team as code owners September 20, 2022 02:31

vmwclabot added the cla-not-required label Sep 20, 2022

jeffwubj changed the title ~~Add aws ebs csi api and controller for classy cluster~~ [WIP] Add aws ebs csi api and controller for classy cluster Sep 20, 2022

jeffwubj force-pushed the topic/jeffwubj/ebs-cc-support branch from 24f2dd7 to 6d867ab Compare September 20, 2022 09:27

jeffwubj changed the title ~~[WIP] Add aws ebs csi api and controller for classy cluster~~ Add aws ebs csi api and controller for classy cluster Sep 21, 2022

jeffwubj force-pushed the topic/jeffwubj/ebs-cc-support branch from f4a104c to fcce669 Compare September 22, 2022 03:25

jeffwubj force-pushed the topic/jeffwubj/ebs-cc-support branch from 384ab6c to 19ce2fb Compare September 22, 2022 09:42

jeffwubj force-pushed the topic/jeffwubj/ebs-cc-support branch from 19ce2fb to 7899e5b Compare September 22, 2022 11:00

jeffwubj force-pushed the topic/jeffwubj/ebs-cc-support branch from 7899e5b to 3d7ada1 Compare September 24, 2022 01:14

jeffwubj force-pushed the topic/jeffwubj/ebs-cc-support branch from 68be32d to 20df9aa Compare September 25, 2022 12:44

jeffwubj force-pushed the topic/jeffwubj/ebs-cc-support branch 2 times, most recently from 4cf3e1b to 7d8e193 Compare September 25, 2022 14:36

jeffwubj force-pushed the topic/jeffwubj/ebs-cc-support branch from 7d8e193 to d120696 Compare September 26, 2022 03:07

jeffwubj force-pushed the topic/jeffwubj/ebs-cc-support branch from d120696 to fa0cfe4 Compare September 26, 2022 16:03

DanielXiao reviewed Sep 30, 2022

View reviewed changes

addons/controllers/awsebscsi/awsescsiconfig_utils.go Outdated Show resolved Hide resolved

jeffwubj force-pushed the topic/jeffwubj/ebs-cc-support branch 3 times, most recently from f60e6cd to 4dd3bde Compare October 10, 2022 01:19

DanielXiao reviewed Oct 10, 2022

View reviewed changes

wjun approved these changes Oct 10, 2022

View reviewed changes

wjun added the ok-to-merge PRs should be labelled with this before merging label Oct 10, 2022

jeffwubj force-pushed the topic/jeffwubj/ebs-cc-support branch 4 times, most recently from ec1bdcd to 42e3dae Compare October 14, 2022 03:56

jeffwubj force-pushed the topic/jeffwubj/ebs-cc-support branch from 42e3dae to ace83d1 Compare October 14, 2022 12:56

jeffwubj added 5 commits October 19, 2022 02:08

Add aws ebs csi api and controller for classy cluster

294eee9

CI & UT & Related codes fix

a0880c5

tests

61c22b6

address review comments

661e697

update e2e after rebase

17d5b2a

jeffwubj force-pushed the topic/jeffwubj/ebs-cc-support branch from f5091c8 to 17d5b2a Compare October 19, 2022 02:13

jeffwubj merged commit 5f5ca70 into main Oct 19, 2022

jeffwubj deleted the topic/jeffwubj/ebs-cc-support branch October 19, 2022 07:24

jeffwubj added a commit that referenced this pull request Oct 24, 2022

Add aws ebs csi api and controller for classy cluster (#3424)

86ee9c5

* Add aws ebs csi api and controller for classy cluster * CI & UT & Related codes fix * tests * address review comments * update e2e after rebase

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add aws ebs csi api and controller for classy cluster #3424

Add aws ebs csi api and controller for classy cluster #3424

jeffwubj commented Sep 20, 2022 •

edited

Loading

github-actions bot commented Sep 20, 2022

codecov bot commented Sep 20, 2022 •

edited

Loading

github-actions bot commented Sep 20, 2022

github-actions bot commented Sep 21, 2022

github-actions bot commented Sep 22, 2022

github-actions bot commented Sep 22, 2022

github-actions bot commented Sep 22, 2022

github-actions bot commented Sep 22, 2022

github-actions bot commented Sep 24, 2022

github-actions bot commented Sep 25, 2022

github-actions bot commented Sep 25, 2022

github-actions bot commented Sep 25, 2022

github-actions bot commented Sep 26, 2022

github-actions bot commented Sep 30, 2022

randomvariable commented Oct 5, 2022

github-actions bot commented Oct 10, 2022

github-actions bot commented Oct 10, 2022

DanielXiao Oct 10, 2022 •

edited

Loading

wjun left a comment

github-actions bot commented Oct 14, 2022

github-actions bot commented Oct 14, 2022

github-actions bot commented Oct 14, 2022

jeffwubj commented Oct 15, 2022

github-actions bot commented Oct 19, 2022

Add aws ebs csi api and controller for classy cluster #3424

Add aws ebs csi api and controller for classy cluster #3424

Conversation

jeffwubj commented Sep 20, 2022 • edited Loading

What this PR does / why we need it

Which issue(s) this PR fixes

Describe testing done for PR

Release note

Additional information

Special notes for your reviewer

github-actions bot commented Sep 20, 2022

codecov bot commented Sep 20, 2022 • edited Loading

Codecov Report

github-actions bot commented Sep 20, 2022

github-actions bot commented Sep 21, 2022

github-actions bot commented Sep 22, 2022

github-actions bot commented Sep 22, 2022

github-actions bot commented Sep 22, 2022

github-actions bot commented Sep 22, 2022

github-actions bot commented Sep 24, 2022

github-actions bot commented Sep 25, 2022

github-actions bot commented Sep 25, 2022

github-actions bot commented Sep 25, 2022

github-actions bot commented Sep 26, 2022

github-actions bot commented Sep 30, 2022

randomvariable commented Oct 5, 2022

github-actions bot commented Oct 10, 2022

github-actions bot commented Oct 10, 2022

DanielXiao Oct 10, 2022 • edited Loading

Choose a reason for hiding this comment

wjun left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 14, 2022

github-actions bot commented Oct 14, 2022

github-actions bot commented Oct 14, 2022

jeffwubj commented Oct 15, 2022

github-actions bot commented Oct 19, 2022

jeffwubj commented Sep 20, 2022 •

edited

Loading

codecov bot commented Sep 20, 2022 •

edited

Loading

DanielXiao Oct 10, 2022 •

edited

Loading