Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Removing tkrtypes directory by moving in required code to registry package #3430

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

sathyanarays
Copy link
Contributor

@sathyanarays sathyanarays commented Sep 20, 2022

Removing tkrtypes directory by moving in required code to registry package

Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@.vmware.com>

What this PR does / why we need it

Removing tkrtypes directory by moving in required code to registry package

Which issue(s) this PR fixes

Fixes #3426
Related to PR #3294

Describe testing done for PR

testing in progress

…y directory

Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@.vmware.com>
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3430/20220920080808/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #3430 (9bbb2fc) into main (8a526ce) will increase coverage by 6.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3430      +/-   ##
==========================================
+ Coverage   46.91%   53.13%   +6.21%     
==========================================
  Files         265      103     -162     
  Lines       28879    10419   -18460     
==========================================
- Hits        13550     5536    -8014     
+ Misses      14082     4428    -9654     
+ Partials     1247      455     -792     
Impacted Files Coverage Δ
cmd/cli/plugin/cluster/available_upgrade.go 16.32% <ø> (ø)
cmd/cli/plugin/cluster/create.go 41.30% <ø> (ø)
cmd/cli/plugin/cluster/credentials_update.go 9.23% <ø> (ø)
cmd/cli/plugin/cluster/delete.go 12.50% <ø> (ø)
...md/cli/plugin/cluster/delete_machinehealthcheck.go 19.23% <ø> (ø)
...cluster/delete_machinehealthcheck_control_plane.go 16.66% <ø> (ø)
...i/plugin/cluster/delete_machinehealthcheck_node.go 16.66% <ø> (ø)
cmd/cli/plugin/cluster/delete_node_pool.go 16.66% <ø> (ø)
cmd/cli/plugin/cluster/get.go 6.27% <ø> (ø)
cmd/cli/plugin/cluster/get_machinehealthcheck.go 11.42% <ø> (ø)
... and 185 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anujc25 anujc25 added the ok-to-merge PRs should be labelled with this before merging label Sep 20, 2022
@anujc25 anujc25 merged commit 6ab1811 into main Sep 20, 2022
@anujc25 anujc25 deleted the sathyanarays/tkrtypes_remove branch September 20, 2022 16:12
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required kind/refactor ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tkg go module's dependency on tkrtypes should be removed
4 participants