This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Clusterbootstrap_controller should watch providers in core packages #3440
+333
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update watches to include providers in core packages Signed-off-by: Vijay Katam <vkatam@vmware.com>
12345lcr
reviewed
Sep 21, 2022
| } | ||
| err := k8sClient.Create(ctx, ns) | ||
| if err != nil { | ||
| Expect(apierrors.IsAlreadyExists(err)).To(BeTrue()) |
There was a problem hiding this comment.
Since BeforeEach run on every start of It, perhaps combine the 2 It into 1 and separate with By can avoid this duplicate creation error?
There was a problem hiding this comment.
I combined the 2 tests into one.
vijaykatam
force-pushed
the
watch_all_providers
branch
from
541f962 to
b58c36d
Compare
Signed-off-by: Vijay Katam <vkatam@vmware.com>
vijaykatam
force-pushed
the
watch_all_providers
branch
from
b58c36d to
d92a034
Compare
Codecov Report
@@ Coverage Diff @@
## main #3440 +/- ##
==========================================
+ Coverage 52.94% 53.90% +0.95%
==========================================
Files 103 105 +2
Lines 10419 10664 +245
==========================================
+ Hits 5516 5748 +232
- Misses 4443 4450 +7
- Partials 460 466 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
maralavi
approved these changes
Sep 23, 2022
chandrareddyp
pushed a commit
that referenced
this pull request
Sep 25, 2022
…3440) * Clusterbootstrap_controller should watch providers in core packages * Update watches to include providers in core packages Signed-off-by: Vijay Katam <vkatam@vmware.com> * Fix test and update make target for verbose tests Signed-off-by: Vijay Katam <vkatam@vmware.com> Signed-off-by: Vijay Katam <vkatam@vmware.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vijay Katam vkatam@vmware.com
What this PR does / why we need it
Update watches to include providers in core packages so that status updates are immediately propagated
Which issue(s) this PR fixes
Fixes #3477
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer