Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Golang 1.18 #3508

Merged
merged 7 commits into from
Oct 5, 2022
Merged

Golang 1.18 #3508

merged 7 commits into from
Oct 5, 2022

Conversation

seemiller
Copy link
Contributor

What this PR does / why we need it

This PR updates Tanzu Framework to use Go 1.18

Describe testing done for PR

Release note

Update Tanzu Framework to use Go 1.18

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3508/20220929181639/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3508/20220929192724/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3508/20220929200412/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

benjaminapetersen
benjaminapetersen approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for IAM/pinniped.

@seemiller seemiller changed the title Golang 18 Golang 1.18 Sep 29, 2022
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3508/20220930201654/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

tenczar
tenczar approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@tenczar tenczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3508/20221003163030/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Oct 3, 2022 •
edited
Loading

Codecov Report

Merging #3508 (9f97128) into main (5e5eb51) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3508      +/-   ##
==========================================
- Coverage   45.30%   45.24%   -0.07%     
==========================================
  Files         370      370              
  Lines       39306    39306              
==========================================
- Hits        17809    17785      -24     
- Misses      19887    19906      +19     
- Partials     1610     1615       +5
Impacted Files Coverage Δ
addons/controllers/clusterbootstrap_controller.go 63.26% <0.00%> (-2.20%) ⬇️
cmd/cli/plugin/tkr/v1alpha3/os.go 73.50% <0.00%> (-0.86%) ⬇️
addons/controllers/machine_controller.go 68.68% <0.00%> (+3.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@seemiller seemiller marked this pull request as ready for review October 4, 2022 16:39
@seemiller seemiller requested review from a team and prkalle as code owners October 4, 2022 16:39
@seemiller seemiller added the ok-to-merge PRs should be labelled with this before merging label Oct 4, 2022
@seemiller seemiller merged commit b6bc162 into vmware-tanzu:main Oct 5, 2022
@seemiller seemiller deleted the golang-18 branch October 5, 2022 19:29
@marckhouzam marckhouzam mentioned this pull request Oct 5, 2022
Closed
marckhouzam added a commit to marckhouzam/tanzu-framework that referenced this pull request Oct 6, 2022
@marckhouzam
Fix Go version
e546731 
We moved to go version with vmware-tanzu#3508, but these two new modules got added
right after.

Signed-off-by: Marc Khouzam <kmarc@vmware.com>
This was referenced Oct 6, 2022
Closed
Closed
Merged
imikushin pushed a commit to imikushin/tanzu-framework that referenced this pull request Oct 6, 2022
Revert "Golang 1.18 (vmware-tanzu#3508)"
a8b48d5 
This reverts commit b6bc162

Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
seemiller added a commit that referenced this pull request Oct 6, 2022
@seemiller
Revert "Golang 1.18 (#3508)" (#3571)
cb7a80c 
This reverts commit b6bc162.
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@tenczar tenczar tenczar approved these changes

@prkalle prkalle Awaiting requested review from prkalle

Assignees
No one assigned
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seemiller @benjaminapetersen @tenczar @vmwclabot