This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Fix simple lint issues under addons and plugin/package directories #3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaykatam
reviewed
Sep 30, 2022
Codecov Report
@@ Coverage Diff @@
## main #3516 +/- ##
==========================================
- Coverage 45.55% 45.55% -0.01%
==========================================
Files 360 360
Lines 38870 38869 -1
==========================================
- Hits 17706 17705 -1
Misses 19560 19560
Partials 1604 1604
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
adduarte
changed the title
adduarte
changed the title
Remove whitespaces Removed duplicate imports Replaced duplicate strings with const (goconst) Removed deadcode Added missing headers (goheader) Removed shadow declarations (govet) Added package comment (stylecheck) Removed unused code (unused) Removed unused value from for loop (revive) Simplified function signature (gocritic) Removed unecessary nil check for map (gosimple) Removed possible security issue Importing "_ net/http/pprof" could lead to security problems. error is: G108: Profiling endpoint is automatically exposed on /debug/pprof (gosec) see https://docs.embold.io/gosec-high-level-issues/ for more details Added //nolint to correct cyclomatic complexity and funclen The functions being tagged with //nolint have already been in production for some time. Correcting the lint error requires heavy refactoring which could introduce problems or new bugs. At this time is best to flagg the functions with //nolint because the risk/reward ratio of refactoring is too high. There is no reward at this time since this functions have already gone extensive testing elsewhere.
adduarte
force-pushed
the
topic/adduarte/fix_addons_lint_error
branch
from
a4e3285 to
584a33a
Compare
vijaykatam
approved these changes
Oct 4, 2022
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Files under the addons directory and cmd/cli/plugin/package directory are failing some golangci-lint tests. This pr addresses some of those issues
Which issue(s) this PR fixes
Fixes # 3436
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer