prevents metric-server from taking ownership of kube-system namespace.

[adduarte]

fixes: 3595

What this PR does / why we need it

prevents metric-server app on administrator cluster from taking ownership of kube-system namespace.
The configuration for the metrics-server which is deployed to the administration server uses the default
("createNamespace: true") when it is to be deployed on the "kube-system" namespace.
Using "createNamespace: true" causes kapp-controller to take ownership of the namespace and assign it to the metrics-server app.
The result is that if a admin user makes any changes to the "kube-system" namespace, they will be reverted back when metric-server app is reconciled by kapp-controller. It also adds kapp.k14s.io annotations and labels to the namespace which can interfere with control-plane operations. For example, when the metric-server app is deleted, the system will try to delete kube-system namespace which is not allowed, resulting in a problem.

Which issue(s) this PR fixes

Fixes # 3595

Describe testing done for PR

Tested by editing the ${CLUSTERNAME}-vc-metrics-server-addon

Release note

prevent metric-server app from taking ownership of kube-system namespace in administrator cluster
labeled kube-system namespace and verified labels are not removed when the metrics-server app is reconciled. 

Additional information

Special notes for your reviewer

[github-actions]

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3596/20221007210401/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

[codecov]

Codecov Report

Merging #3596 (e91b028) into main (2f9044a) will decrease coverage by 0.90%.
The diff coverage is 3.33%.

@@            Coverage Diff             @@
##             main    #3596      +/-   ##
==========================================
- Coverage   46.93%   46.03%   -0.91%     
==========================================
  Files         402      427      +25     
  Lines       40203    41754    +1551     
==========================================
+ Hits        18869    19221     +352     
- Misses      19582    20765    +1183     
- Partials     1752     1768      +16     

Impacted Files	Coverage Δ
cli/runtime/config/clientconfig.go	53.17% <0.00%> (ø)
cmd/cli/plugin/cluster/osimage.go	100.00% <ø> (ø)
cmd/cli/plugin/cluster/osimage_oracle.go	3.20% <0.00%> (ø)
cli/core/pkg/config/edition.go	57.14% <100.00%> (ø)
...in/cluster/set_machinehealthcheck_control_plane.go	21.21% <0.00%> (ø)
cmd/cli/plugin/cluster/get_machinehealthcheck.go	11.42% <0.00%> (ø)
cmd/cli/plugin/cluster/create.go	42.22% <0.00%> (ø)
cmd/cli/plugin/cluster/set_node_pool.go	14.63% <0.00%> (ø)
...md/cli/plugin/cluster/delete_machinehealthcheck.go	19.23% <0.00%> (ø)
...cluster/delete_machinehealthcheck_control_plane.go	16.66% <0.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[randomvariable]

We should merge this one. Can we rebase it @adduarte ?

[github-actions]

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3596/20221110060737/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

[maralavi]

@adduarte Could you please just update this statement in the description?

they will be reverted back when metric-server app is reconciled by addons-manager--> they will be reverted back when metric-server app is reconciled by kapp-controller