Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Fix NSX ALB service engine group & network validation failure when duplicate resource names in different clouds #3602

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Fix NSX ALB service engine group & network validation failure when duplicate resource names in different clouds #3602

merged 1 commit into from
Oct 20, 2022

Conversation

XudongLiuHarold
Copy link
Member

@XudongLiuHarold XudongLiuHarold commented Oct 10, 2022

Signed-off-by: Xudong Liu xudongl@vmware.com

What this PR does / why we need it

  • When there are configured multiple clouds in NSX ALB controller, it is highly possible that customers use the same name for SEG in different clouds, this should be validate case, we should not throw errors about this.

Which issue(s) this PR fixes

Fixes #3603

Describe testing done for PR

  • created vsphere mgmt cluster and verified the change

Release note

Users can now configure the NSX ALB controller with the same ALB resource name across multiple clouds.

Additional information

Special notes for your reviewer

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3602/20221010094810/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3602/20221010101405/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3602/20221010102442/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #3602 (92851c1) into main (5f5ca70) will decrease coverage by 0.90%.
The diff coverage is 100.00%.

❗ Current head 92851c1 differs from pull request most recent head b1dda1e. Consider uploading reports for the commit b1dda1e to get more accurate results

@@            Coverage Diff             @@
##             main    #3602      +/-   ##
==========================================
- Coverage   46.22%   45.32%   -0.91%     
==========================================
  Files         400      425      +25     
  Lines       39624    41190    +1566     
==========================================
+ Hits        18317    18668     +351     
- Misses      19621    20811    +1190     
- Partials     1686     1711      +25     
Impacted Files Coverage Δ
tkg/client/validate.go 58.49% <100.00%> (+0.05%) ⬆️
addons/controllers/machine_controller.go 65.65% <0.00%> (-3.04%) ⬇️
addons/controllers/clusterbootstrap_controller.go 63.26% <0.00%> (-1.61%) ⬇️
...runtime/apis/config/v1alpha1/clientconfig_types.go 100.00% <0.00%> (ø)
cmd/cli/plugin/cluster/get_machinehealthcheck.go 11.42% <0.00%> (ø)
cmd/cli/plugin/cluster/delete_node_pool.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/credentials_update.go 9.23% <0.00%> (ø)
cmd/cli/plugin/cluster/machinehealthcheck.go 100.00% <0.00%> (ø)
cmd/cli/plugin/cluster/main.go 0.00% <0.00%> (ø)
cmd/cli/plugin/cluster/list.go 9.52% <0.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@XudongLiuHarold
Copy link
Member Author

/test install-vc7

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3602/20221012024518/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3602/20221017040016/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

…ate resource names in different cloud

Signed-off-by: Xudong Liu <xudongl@vmware.com>
@XudongLiuHarold
Copy link
Member Author

/test install-vc7

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3602/20221019091931/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable randomvariable added the ok-to-merge PRs should be labelled with this before merging label Oct 19, 2022
@alfredthenarwhal
Copy link
Collaborator

Build failed! Build no: 2948

@XudongLiuHarold XudongLiuHarold merged commit beeebd7 into vmware-tanzu:main Oct 20, 2022
zhouke1991 pushed a commit that referenced this pull request Oct 20, 2022
…ate resource names in different cloud (#3602)

Signed-off-by: Xudong Liu <xudongl@vmware.com>

Signed-off-by: Xudong Liu <xudongl@vmware.com>
jeffwubj pushed a commit that referenced this pull request Oct 24, 2022
…ate resource names in different cloud (#3602)

Signed-off-by: Xudong Liu <xudongl@vmware.com>

Signed-off-by: Xudong Liu <xudongl@vmware.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tanzu validation failed when there are duplicated NSX ALB resource names in different NSX ALB clouds
4 participants