Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Kickstart UI: Remove trailing comma when converting a string map to string #3615

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

miclettej
Copy link
Contributor

Fixes issue with conversion of string map leaving trailing comma on converted single string

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Confirmed that config yaml is written without unexpected trialing comma in converted maps

Release note

Fixes bug in UI related to AVI Labels causing cluster creation failure

Additional information

Special notes for your reviewer

…ingle string

Fixes issue with conversion of string map leaving trailing comma on converted single string
@miclettej miclettej requested review from a team as code owners October 11, 2022 03:10
@miclettej miclettej requested review from vuil and tenczar October 11, 2022 03:12
@miclettej miclettej added the area/ui Specific UI issue/enhancement label Oct 11, 2022
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3615/20221011031719/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3615/20221011033754/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3615/20221011043744/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #3615 (60bf18c) into main (7efdbec) will decrease coverage by 0.86%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3615      +/-   ##
==========================================
- Coverage   46.27%   45.40%   -0.87%     
==========================================
  Files         400      425      +25     
  Lines       39573    41139    +1566     
==========================================
+ Hits        18311    18679     +368     
- Misses      19572    20755    +1183     
- Partials     1690     1705      +15     
Impacted Files Coverage Δ
tkg/tkgconfigproviders/helper.go 100.00% <100.00%> (ø)
cmd/cli/plugin/cluster/create.go 41.30% <0.00%> (ø)
cmd/cli/plugin/cluster/available_upgrade.go 16.32% <0.00%> (ø)
.../cli/plugin/cluster/get_machinehealthcheck_node.go 9.30% <0.00%> (ø)
cmd/cli/plugin/cluster/osimage.go 100.00% <0.00%> (ø)
cmd/cli/plugin/cluster/kubeconfig_get.go 8.82% <0.00%> (ø)
...md/cli/plugin/cluster/delete_machinehealthcheck.go 19.23% <0.00%> (ø)
...in/cluster/get_machinehealthcheck_control_plane.go 11.11% <0.00%> (ø)
cmd/cli/plugin/cluster/set_node_pool.go 14.63% <0.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@swalner-vmware swalner-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miclettej miclettej added the ok-to-merge PRs should be labelled with this before merging label Oct 24, 2022
Copy link
Contributor

@danniel1205 danniel1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the PR

@miclettej miclettej merged commit 8494ab8 into vmware-tanzu:main Oct 24, 2022
m1zzx2 pushed a commit that referenced this pull request Oct 25, 2022
…tring (#3615)

* Kickstart UI: Remove trailing comma when converting a string map to single string

Fixes issue with conversion of string map leaving trailing comma on converted single string

Co-authored-by: Justin Miclette <miclettej@miclettej-a02.vmware.com>
m1zzx2 pushed a commit that referenced this pull request Oct 25, 2022
…tring (#3615)

* Kickstart UI: Remove trailing comma when converting a string map to single string

Fixes issue with conversion of string map leaving trailing comma on converted single string

Co-authored-by: Justin Miclette <miclettej@miclettej-a02.vmware.com>
m1zzx2 pushed a commit that referenced this pull request Oct 31, 2022
…tring (#3615)

* Kickstart UI: Remove trailing comma when converting a string map to single string

Fixes issue with conversion of string map leaving trailing comma on converted single string

Co-authored-by: Justin Miclette <miclettej@miclettej-a02.vmware.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area/ui Specific UI issue/enhancement cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants