-
Notifications
You must be signed in to change notification settings - Fork 192
Kickstart UI: Remove trailing comma when converting a string map to string #3615
Kickstart UI: Remove trailing comma when converting a string map to string #3615
Conversation
…ingle string Fixes issue with conversion of string map leaving trailing comma on converted single string
Cluster Generation A/B Results: |
Cluster Generation A/B Results: |
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #3615 +/- ##
==========================================
- Coverage 46.27% 45.40% -0.87%
==========================================
Files 400 425 +25
Lines 39573 41139 +1566
==========================================
+ Hits 18311 18679 +368
- Misses 19572 20755 +1183
- Partials 1690 1705 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the PR
…tring (#3615) * Kickstart UI: Remove trailing comma when converting a string map to single string Fixes issue with conversion of string map leaving trailing comma on converted single string Co-authored-by: Justin Miclette <miclettej@miclettej-a02.vmware.com>
…tring (#3615) * Kickstart UI: Remove trailing comma when converting a string map to single string Fixes issue with conversion of string map leaving trailing comma on converted single string Co-authored-by: Justin Miclette <miclettej@miclettej-a02.vmware.com>
…tring (#3615) * Kickstart UI: Remove trailing comma when converting a string map to single string Fixes issue with conversion of string map leaving trailing comma on converted single string Co-authored-by: Justin Miclette <miclettej@miclettej-a02.vmware.com>
Fixes issue with conversion of string map leaving trailing comma on converted single string
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Confirmed that config yaml is written without unexpected trialing comma in converted maps
Release note
Additional information
Special notes for your reviewer