-
Notifications
You must be signed in to change notification settings - Fork 192
Remove BOMRepo
and CompatibilityFilePath
dependency from ClientConfig
#3639
Conversation
Cluster Generation A/B Results: |
79bb89e
to
f863b3d
Compare
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #3639 +/- ##
==========================================
- Coverage 46.21% 45.30% -0.92%
==========================================
Files 400 425 +25
Lines 39624 41180 +1556
==========================================
+ Hits 18314 18655 +341
- Misses 19618 20817 +1199
- Partials 1692 1708 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
f863b3d
to
f3c8f6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, but sounds good to me.
…Config Signed-off-by: Anuj Chaudhari <anujc@vmware.com>
f3c8f6a
to
9b6294f
Compare
Cluster Generation A/B Results: |
…Config (#3639) Signed-off-by: Anuj Chaudhari <anujc@vmware.com> Signed-off-by: Anuj Chaudhari <anujc@vmware.com>
What this PR does / why we need it
For
BomRepo
andCompatibilityFilePath
fields in ClientConfig, thecluster
andmanagement-cluster
plugins are not reading on this information from ClientConfig. However, plugins are configuring this fields when invoking the commands.Reference: As part of PR #3264 we removed the dependency of plugins on ClientConfig.
Also, core CLI is always making sure that this fields are configured in the ClientConfig to support older plugins.
So, This PR removes the
SetCompatibilityFileBasedOnEdition
invocation as part of plugin code and marks fields as Deprecated.Which issue(s) this PR fixes
Related to #3149
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer