Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Adding missing Antrea 1.5.3 spec configurations #3650

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

knabben
Copy link
Member

@knabben knabben commented Oct 13, 2022

What this PR does / why we need it

Adding missing configuration for Antrea 1.5.3 AntreaConfig

Removed dualstack checks, setting only IPv4
Moving to a topic branch.
#3252

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Update Clusterbootstrap to read and parse variables for Antrea 1.5.3

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3650/20221013175355/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #3650 (cca02b4) into main (321c521) will decrease coverage by 0.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3650      +/-   ##
==========================================
- Coverage   46.24%   45.39%   -0.86%     
==========================================
  Files         400      425      +25     
  Lines       39630    41194    +1564     
==========================================
+ Hits        18328    18698     +370     
- Misses      19611    20792    +1181     
- Partials     1691     1704      +13     
Impacted Files Coverage Δ
tkg/tkgconfighelper/validate.go 81.81% <0.00%> (ø)
cmd/cli/plugin/cluster/set_node_pool.go 14.63% <0.00%> (ø)
cmd/cli/plugin/cluster/credentials_update.go 9.23% <0.00%> (ø)
cmd/cli/plugin/cluster/upgrade.go 57.55% <0.00%> (ø)
.../cli/plugin/cluster/set_machinehealthcheck_node.go 23.33% <0.00%> (ø)
...in/cluster/get_machinehealthcheck_control_plane.go 11.11% <0.00%> (ø)
cmd/cli/plugin/cluster/scale.go 17.85% <0.00%> (ø)
...cluster/delete_machinehealthcheck_control_plane.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/osimage.go 100.00% <0.00%> (ø)
cmd/cli/plugin/cluster/machinehealthcheck.go 100.00% <0.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@wjun wjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wjun wjun added the ok-to-merge PRs should be labelled with this before merging label Oct 19, 2022
@wjun
Copy link
Contributor

wjun commented Oct 19, 2022

Please do not use a forked branch when the pr will trigger capa or capd integration tests.

@knabben knabben merged commit 130b0f3 into vmware-tanzu:main Oct 19, 2022
@knabben knabben deleted the topic/knabben/antreaconfig branch October 19, 2022 10:03
@knabben knabben restored the topic/knabben/antreaconfig branch October 20, 2022 01:51
knabben added a commit that referenced this pull request Oct 20, 2022
wjun pushed a commit that referenced this pull request Oct 20, 2022
jeffwubj pushed a commit that referenced this pull request Oct 24, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants