Removes requirement adddon configs match cluster name

[adduarte]

allowing the name of addons config to be anything

controllers changed in this patch

• Calico CNI
• Antrea CNI
• CSI
• CPI
• Kapp Controller

scenario logic:

• no customization
  user does nothing
  addonsNS/config-template is cloned to clusterNS/{CLUSTER_NAME}-{pacakge-short-name}-package
  CLUSTER_NAME will be added the owner references of clusterNS/{CLUSTER_NAME}-{pacakge-short-name}-package
  data value secrets is created

• customize based on template:
  create clusterNS/addonconfig withname clusterNS/{CLUSTER_NAMEW}-{package-short-name}-pacakge
  then
  clusterNS/{CLUSTER_NAME}-{pacakge-short-name}-package += addonsNS/config-template

  The resulting addon config is a merged of template with user defined config addon
  The values from user defined addon config take precedence over the values from template config
  and CLUSTER_NAME will be added the owner references of clusterNS/{CLUSTER_NAME}-{pacakge-short-name}-
  package
  data value secrets is created

• customized based custom clusterboostrap and custom addonconfig:
  create clusterNS/addonconfig withname clusterNS/{Any-name-for-addon-config}
  webhook adds all undefined necessary fields.
  create clusterbootsrap clusterNS/{CLUSTER_NAME} pointing to clusterNS/{Any-name-for-addon-config}
  CLUSTER_NAME will be added the owner references of clusterNS/{Any-name-for-addon-config}
  data value secrets is created

• customized based custom clusterboostrap and custom addonconfig with wildcard:
  create clusterNS/addonconfig withname clusterNS/{Any-name-for-addon-config}
  webhook adds all undefined necessary fields.
  create clusterbootsrap clusterNS/{CLUSTER_NAME} pointing to clusterNS/{Any-name-for-addon-config}
  CLUSTER_NAME will be added the owner references of clusterNS/{Any-name-for-addon-config}
  data value secrets is created

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

scenarios described have been added as tests using eventest library
unit tests defined

Release note

Remove requirements that user defined addon config match cluster name. 
Addon configs can be based on addonConfig templates plus user defined values by using predefined name for addon config
User defined addon configs must be used in conjunction with user defined clusterboostrap

Additional information

Special notes for your reviewer

[codecov]

Codecov Report

Merging #3652 (c7310e6) into main (a462bbe) will decrease coverage by 0.91%.
The diff coverage is 60.21%.

❗ Current head c7310e6 differs from pull request most recent head 196073f. Consider uploading reports for the commit 196073f to get more accurate results

@@            Coverage Diff             @@
##             main    #3652      +/-   ##
==========================================
- Coverage   46.55%   45.64%   -0.92%     
==========================================
  Files         400      426      +26     
  Lines       39797    41630    +1833     
==========================================
+ Hits        18529    19002     +473     
- Misses      19571    20898    +1327     
- Partials     1697     1730      +33     

Impacted Files	Coverage Δ
addons/controllers/clusterbootstrap_controller.go	63.36% <42.85%> (+0.46%)	⬆️
...til/clusterbootstrapclone/clusterbootstrapclone.go	67.40% <54.42%> (-2.97%)	⬇️
addons/controllers/utils/utils.go	25.89% <90.62%> (ø)
cli/core/pkg/config/features.go	58.00% <0.00%> (-32.63%)	⬇️
packageclients/pkg/packageclient/package_update.go	83.57% <0.00%> (-1.43%)	⬇️
...ons/controllers/packageinstallstatus_controller.go	77.99% <0.00%> (-1.16%)	⬇️
cmd/cli/plugin/tkr/v1alpha3/os.go	73.50% <0.00%> (-0.86%)	⬇️
cli/core/pkg/pluginmanager/manager.go	62.37% <0.00%> (-0.31%)	⬇️
tkg/aws/client.go	20.33% <0.00%> (ø)
tkg/client/utils.go	36.10% <0.00%> (ø)
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[shyaamsn]

/test install-vc7

[alfredthenarwhal]

Build failed! Build no: 3097

[adduarte]

/test install-vc7

[shyaamsn]

/test install-vc7

[shyaamsn]

Not sure why codecov is reporting that no test is covering this. I thought you have added a test case for this ? Could you please ensure this is covered as part of the test.

[adduarte]

will do

[shyaamsn]

LGTM