Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Fix bastion host variable on AWS #3675

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Conversation

ydp
Copy link

@ydp ydp commented Oct 15, 2022

What this PR does / why we need it

The old code to receive bastion host variable by if condition is setting the value as true in all conditions, fix it by using the variable directly.

Which issue(s) this PR fixes

Part of #3616

Describe testing done for PR

Release note

Support disable bastion host in classy cluster on AWS

Additional information

Special notes for your reviewer

@ydp ydp requested review from a team as code owners October 15, 2022 04:44
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3675/20221015045358/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@ydp ydp force-pushed the topic/dingpingy/bastion-aws branch from 150872c to 30a104b Compare October 15, 2022 06:17
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3675/20221015062952/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #3675 (30a104b) into main (f3c0f92) will decrease coverage by 0.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3675      +/-   ##
==========================================
- Coverage   46.30%   45.34%   -0.97%     
==========================================
  Files         400      425      +25     
  Lines       39624    41188    +1564     
==========================================
+ Hits        18347    18675     +328     
- Misses      19594    20804    +1210     
- Partials     1683     1709      +26     
Impacted Files Coverage Δ
...oller-manager/controllers/v3_cascade_controller.go 61.90% <0.00%> (-3.81%) ⬇️
addons/controllers/machine_controller.go 65.65% <0.00%> (-3.04%) ⬇️
...tanzu-auth-controller-manager/controllers/utils.go 72.58% <0.00%> (-1.62%) ⬇️
addons/controllers/clusterbootstrap_controller.go 63.85% <0.00%> (-1.61%) ⬇️
cmd/cli/plugin/cluster/osimage_oracle.go 3.22% <0.00%> (ø)
cmd/cli/plugin/cluster/credentials_update.go 9.23% <0.00%> (ø)
cmd/cli/plugin/cluster/delete_node_pool.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/get.go 6.27% <0.00%> (ø)
cmd/cli/plugin/cluster/osimage.go 100.00% <0.00%> (ø)
cmd/cli/plugin/cluster/machinehealthcheck.go 100.00% <0.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@randomvariable randomvariable added the ok-to-merge PRs should be labelled with this before merging label Oct 17, 2022
@randomvariable randomvariable merged commit 3800080 into main Oct 17, 2022
@randomvariable randomvariable deleted the topic/dingpingy/bastion-aws branch October 17, 2022 10:15
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants