Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Add proxy configuration to tkrSourceControllerPackage when creating MC #3751

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

lubronzhan
Copy link
Contributor

@lubronzhan lubronzhan commented Oct 25, 2022

What this PR does / why we need it

CLI is not injecting proxy settings to tkrSourceControllerPackage, causing it failing to pull images

Which issue(s) this PR fixes

Fixes ##3754

Describe testing done for PR

Release note

Add proxy configuration to tkrSourceControllerPackage when creating MC

Additional information

Special notes for your reviewer

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3751/20221025231609/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@lubronzhan lubronzhan changed the title Add proxy configuration to tkrSourceControllerPackage Add proxy configuration to tkrSourceControllerPackage when creating MC Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #3751 (a18bbe0) into main (a72b141) will decrease coverage by 0.56%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3751      +/-   ##
==========================================
- Coverage   46.24%   45.67%   -0.57%     
==========================================
  Files         400      425      +25     
  Lines       39642    41292    +1650     
==========================================
+ Hits        18331    18860     +529     
- Misses      19623    20720    +1097     
- Partials     1688     1712      +24     
Impacted Files Coverage Δ
tkg/managementcomponents/helper.go 94.11% <100.00%> (+2.01%) ⬆️
addons/controllers/machine_controller.go 65.65% <0.00%> (-3.04%) ⬇️
...ons/controllers/packageinstallstatus_controller.go 77.99% <0.00%> (-1.16%) ⬇️
addons/controllers/clusterbootstrap_controller.go 63.04% <0.00%> (-0.81%) ⬇️
tkg/client/init.go 0.00% <0.00%> (ø)
tkg/tkgconfigproviders/helper.go 100.00% <0.00%> (ø)
capabilities/client/pkg/discovery/fake.go 100.00% <0.00%> (ø)
tkg/client/upgrade_cluster_clusterclass.go 100.00% <0.00%> (ø)
cmd/cli/plugin/cluster/osimage.go 100.00% <0.00%> (ø)
...md/cli/plugin/cluster/delete_machinehealthcheck.go 19.23% <0.00%> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@imikushin imikushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubronzhan lubronzhan added the ok-to-merge PRs should be labelled with this before merging label Oct 26, 2022
@lubronzhan lubronzhan merged commit 8147890 into vmware-tanzu:main Oct 26, 2022
@lubronzhan lubronzhan deleted the topic/lubron/fix_proxy branch October 26, 2022 17:30
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants