-
Notifications
You must be signed in to change notification settings - Fork 192
Replicate TKR and OSImage to cleanup cluster during management cluster deletion. #3755
Conversation
Cluster Generation A/B Results: |
817c634
to
87f3f63
Compare
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #3755 +/- ##
==========================================
- Coverage 46.58% 45.70% -0.88%
==========================================
Files 400 425 +25
Lines 39710 41336 +1626
==========================================
+ Hits 18497 18891 +394
- Misses 19523 20737 +1214
- Partials 1690 1708 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
87f3f63
to
f5aca00
Compare
Cluster Generation A/B Results: |
f5aca00
to
f505bb4
Compare
Cluster Generation A/B Results: |
f505bb4
to
beaeb21
Compare
Cluster Generation A/B Results: |
beaeb21
to
e1f3059
Compare
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it
A follow-up of #3724, cherrypicked from #3557
During the management cluster deletion, if the user has brought their own TKR and OSImages, then in the cleanup cluster, the moved Cluster CR will be rejected by the TKR cluster webhook. A sample error looks like,
This is because the TKR Cluster webhook rejects the moved Cluster CR because of lacking the self-brought TKR and OSImages in the cleanup cluster.
Therefore, when performing region deletion, the tanzu CLI should be responsible for replicating the TKR and OSImages that is associated with the moved management cluster. This PR adds this extra step.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
With this fix presented at #3557, the Oracle management cluster is able to be deleted successfully and the webhook no longer rejects with moved Cluster.
Release note
Additional information
Special notes for your reviewer