Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Remove extra space in no_proxy definition #3764

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

lubronzhan
Copy link
Contributor

What this PR does / why we need it

Creating management cluster with proxy will fail. Since there are extra space in the no_proxy settings, making the kubeadm command to error out, thus kube-apiserver is not getting correct NO_PROXY value

Which issue(s) this PR fixes

Fixes ##3763

Describe testing done for PR

Release note

Remove extra space in no_proxy in clusterclass template

Additional information

Special notes for your reviewer

@lubronzhan lubronzhan requested review from a team as code owners October 26, 2022 21:02
@lubronzhan lubronzhan changed the title Fix the extra space in no_proxy Remove extra space in no_proxy definition Oct 26, 2022
@lubronzhan
Copy link
Contributor Author

/test install-vc7

Copy link
Contributor

@tenczar tenczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix this issue in azure/aws as well.

providers/infrastructure-vsphere/v1.3.1/cconly/base.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@tenczar tenczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@HanFa HanFa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3764/20221026221521/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #3764 (b0f1255) into main (395ef34) will decrease coverage by 0.93%.
The diff coverage is 66.66%.

❗ Current head b0f1255 differs from pull request most recent head fc0edba. Consider uploading reports for the commit fc0edba to get more accurate results

@@            Coverage Diff             @@
##             main    #3764      +/-   ##
==========================================
- Coverage   46.65%   45.71%   -0.94%     
==========================================
  Files         400      425      +25     
  Lines       39722    41278    +1556     
==========================================
+ Hits        18531    18870     +339     
- Misses      19498    20694    +1196     
- Partials     1693     1714      +21     
Impacted Files Coverage Δ
tkg/client/init.go 0.00% <0.00%> (ø)
tkg/client/machine_deployment.go 61.86% <ø> (ø)
tkg/client/upgrade_cluster.go 44.62% <66.66%> (ø)
tkg/clusterclient/clusterclient.go 49.34% <85.71%> (ø)
...oller-manager/controllers/v3_cascade_controller.go 61.90% <0.00%> (-11.43%) ⬇️
packageclients/pkg/packageclient/package_update.go 83.57% <0.00%> (-1.43%) ⬇️
addons/controllers/clusterbootstrap_controller.go 63.04% <0.00%> (-0.59%) ⬇️
...in/cluster/set_machinehealthcheck_control_plane.go 21.21% <0.00%> (ø)
...in/cluster/get_machinehealthcheck_control_plane.go 11.11% <0.00%> (ø)
cmd/cli/plugin/cluster/delete.go 12.50% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alfredthenarwhal
Copy link
Collaborator

Tests passed! Build no: 3040

@lubronzhan lubronzhan force-pushed the topic/lubron/fix_proxy branch from d1ff32b to afa4552 Compare October 27, 2022 19:11
@lubronzhan
Copy link
Contributor Author

/test install-vc7

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3764/20221027192109/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@alfredthenarwhal
Copy link
Collaborator

Tests failed! Build no: 3048

@lubronzhan lubronzhan force-pushed the topic/lubron/fix_proxy branch from afa4552 to cb18b92 Compare October 28, 2022 23:25
@lubronzhan
Copy link
Contributor Author

/test install-vc7

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3764/20221029003700/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@alfredthenarwhal
Copy link
Collaborator

Tests failed! Build no: 3060

@lubronzhan lubronzhan requested a review from a team as a code owner October 31, 2022 18:26
@lubronzhan lubronzhan force-pushed the topic/lubron/fix_proxy branch from 579c0a5 to b0f1255 Compare October 31, 2022 18:39
@lubronzhan
Copy link
Contributor Author

/test install-vc7

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3764/20221031184942/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@alfredthenarwhal
Copy link
Collaborator

Build failed! Build no: 3072

@lubronzhan lubronzhan added the ok-to-merge PRs should be labelled with this before merging label Nov 1, 2022
@lubronzhan lubronzhan force-pushed the topic/lubron/fix_proxy branch from b0f1255 to fc0edba Compare November 1, 2022 01:21
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3764/20221101013206/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@lubronzhan lubronzhan merged commit 986bff7 into vmware-tanzu:main Nov 1, 2022
@lubronzhan lubronzhan deleted the topic/lubron/fix_proxy branch November 1, 2022 05:23
m1zzx2 pushed a commit that referenced this pull request Nov 1, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants