-
Notifications
You must be signed in to change notification settings - Fork 192
Remove extra space in no_proxy definition #3764
Remove extra space in no_proxy definition #3764
Conversation
/test install-vc7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we fix this issue in azure/aws as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #3764 +/- ##
==========================================
- Coverage 46.65% 45.71% -0.94%
==========================================
Files 400 425 +25
Lines 39722 41278 +1556
==========================================
+ Hits 18531 18870 +339
- Misses 19498 20694 +1196
- Partials 1693 1714 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Tests passed! Build no: 3040 |
d1ff32b
to
afa4552
Compare
/test install-vc7 |
Cluster Generation A/B Results: |
Tests failed! Build no: 3048 |
afa4552
to
cb18b92
Compare
/test install-vc7 |
Cluster Generation A/B Results: |
Tests failed! Build no: 3060 |
579c0a5
to
b0f1255
Compare
/test install-vc7 |
Cluster Generation A/B Results: |
Build failed! Build no: 3072 |
b0f1255
to
fc0edba
Compare
Cluster Generation A/B Results: |
What this PR does / why we need it
Creating management cluster with proxy will fail. Since there are extra space in the no_proxy settings, making the kubeadm command to error out, thus kube-apiserver is not getting correct NO_PROXY value
Which issue(s) this PR fixes
Fixes ##3763
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer