-
Notifications
You must be signed in to change notification settings - Fork 192
Make feature plugin work for Feature and FeatureGate APIs in core.tanzu.vmware.com #3850
Conversation
0ec768d
to
c65d3ae
Compare
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #3850 +/- ##
==========================================
- Coverage 46.95% 46.10% -0.85%
==========================================
Files 402 434 +32
Lines 40251 42158 +1907
==========================================
+ Hits 18898 19437 +539
- Misses 19605 20942 +1337
- Partials 1748 1779 +31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a Round 1 review, need to review this more thoroughly
Cluster Generation A/B Results: |
772cfaa
to
aad27db
Compare
Cluster Generation A/B Results: |
aad27db
to
0ff238e
Compare
c54db79
to
47d3a48
Compare
fe26948
to
df68d5e
Compare
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure release note is updated with breaking changes and what users can use as an alternative.
@rajathagasthya. I updated the release note to contain your suggestions,
Let me know if it can be improved. |
Cluster Generation A/B Results: |
ca8bfab
to
37569c1
Compare
Cluster Generation A/B Results: |
37569c1
to
68ef063
Compare
…e) v1alpha2 APIs - update feature plugin and client code to work with core.tanzu.vmware.com APIs - update unit tests for both plugin and client Signed-off-by: F. Gold <fgold@vmware.com>
68ef063
to
0495a94
Compare
What this PR does / why we need it
This PR updates the Tanzu CLI plugin for managing Features on a cluster. It required updating the FeatureGate client in order to make the plugin work. Unit tests for the plugin and client have been updated.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Unit tests are passing, but the plugin code test coverage is less than 33% while the client test coverage rounds up to 70%. Increased unit test coverage for the plugin will happen in a future PR.
I have done some manual testing by setting up the new Feature controller and Feature(Gate) APIs. I have documented the commands I ran in a gist: https://gist.github.com/codegold79/0b4e76d437e58173dc17fbb2047e2e69
Please ignore the FeatureGate status section as the logic for the controller is not in the scope of this Tanzu CLI Feature plugin PR.
Release note
Additional information
Special notes for your reviewer