This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Label legacy TKRs as such #3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TKRs without bootstrap packages will now be labeled with label run.tanzu.vmware.com/legacy-tkr: '' Bootstrap packages were introduced in TKR API v1alpha3, so any TKRs converted from previous API versions won't have them. Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
imikushin
added
area/api
area/tkr
ok-to-merge
Codecov Report
@@ Coverage Diff @@
## main #3858 +/- ##
==========================================
- Coverage 46.56% 45.69% -0.88%
==========================================
Files 400 426 +26
Lines 39830 41688 +1858
==========================================
+ Hits 18548 19049 +501
- Misses 19584 20908 +1324
- Partials 1698 1731 +33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
prkalle
approved these changes
Nov 8, 2022
Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
xiujuanx
pushed a commit
that referenced
this pull request
Nov 14, 2022
TKRs without bootstrap packages will now be labeled with label run.tanzu.vmware.com/legacy-tkr: '' Bootstrap packages were introduced in TKR API v1alpha3, so any TKRs converted from previous API versions won't have them. Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
TKRs without bootstrap packages will now be labeled with label
run.tanzu.vmware.com/legacy-tkr: ''Bootstrap packages were introduced in TKR API v1alpha3, so any TKRs converted from previous API versions won't have them.
Which issue(s) this PR fixes
Fixes #3873.
Describe testing done for PR
Added unit tests.
Release note
Additional information
Special notes for your reviewer