Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Oracle Support - Add CPI and CSI reconciler for Oracle Cloud to TKG Addons Controller #3898

Merged
merged 6 commits into from
Nov 16, 2022
Merged

Oracle Support - Add CPI and CSI reconciler for Oracle Cloud to TKG Addons Controller #3898

merged 6 commits into from
Nov 16, 2022

Conversation

HanFa
Copy link
Contributor

@HanFa HanFa commented Nov 10, 2022 •
edited
Loading

Co-authored-by: Fang Han fhan@vmware.com
Co-authored-by: Xudong Liu xudongl@vmware.com
Signed-off-by: Naadir Jeewa jeewan@vmware.com

What this PR does / why we need it

Required by and cherry-picked from the Oracle Support, #3557, documented in #3600

Add Oracle CPI package, CR and its CPIConfig controller.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Oracle Support - Add CPI and CSI reconciler for Oracle Cloud to TKG Addons Controller

Additional information

Special notes for your reviewer

@HanFa @XudongLiuHarold
Add CPI and CSI reconciler for Oracle Cloud to TKG Addons Controller
3890499 
Co-authored-by: Fang Han <fhan@vmware.com>
Co-authored-by: Xudong Liu <xudongl@vmware.com>
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@HanFa HanFa requested review from a team as code owners November 10, 2022 23:55
@HanFa HanFa changed the title Add CPI and CSI reconciler for Oracle Cloud to TKG Addons Controller Oracle Support - Add CPI and CSI reconciler for Oracle Cloud to TKG Addons Controller Nov 10, 2022
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3898/20221111001023/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable
Copy link
Contributor

Some build errors on this PR.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3898/20221114145839/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@HanFa
Copy link
Contributor Author

HanFa commented Nov 14, 2022

Fixed the addon test. retriggering CI

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3898/20221114191353/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@HanFa HanFa force-pushed the topic/fhan/oracle-cpi-init branch from ed12907 to bb6dc3a Compare November 14, 2022 22:16
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3898/20221114222230/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3898/20221115001200/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Nov 15, 2022 •
edited
Loading

Codecov Report

Merging #3898 (234bea3) into main (1ab6021) will decrease coverage by 0.96%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3898      +/-   ##
==========================================
- Coverage   46.97%   46.01%   -0.97%     
==========================================
  Files         402      427      +25     
  Lines       40203    41822    +1619     
==========================================
+ Hits        18887    19246     +359     
- Misses      19569    20806    +1237     
- Partials     1747     1770      +23
Impacted Files Coverage Δ
addons/pkg/util/cluster_util.go 4.28% <0.00%> (-0.07%) ⬇️
addons/controllers/machine_controller.go 65.65% <0.00%> (-3.04%) ⬇️
addons/controllers/clusterbootstrap_controller.go 63.36% <0.00%> (-1.50%) ⬇️
tkg/clusterclient/clusterclient.go 48.27% <0.00%> (-0.39%) ⬇️
tkg/client/cluster.go 26.65% <0.00%> (-0.28%) ⬇️
tkg/client/upgrade_cluster.go 44.63% <0.00%> (-0.05%) ⬇️
tkg/client/init.go 0.00% <0.00%> (ø)
tkg/tkgctl/init.go 0.00% <0.00%> (ø)
tkg/client/client.go 81.25% <0.00%> (ø)
tkg/tkgconfigbom/bom_types.go 0.00% <0.00%> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3898/20221115024401/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@HanFa HanFa force-pushed the topic/fhan/oracle-cpi-init branch from cce38cb to d57c64a Compare November 15, 2022 23:04
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3898/20221115231052/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3898/20221115231112/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@HanFa HanFa force-pushed the topic/fhan/oracle-cpi-init branch from d57c64a to 234bea3 Compare November 15, 2022 23:53
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3898/20221115235915/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

XudongLiuHarold
XudongLiuHarold approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@XudongLiuHarold XudongLiuHarold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XudongLiuHarold XudongLiuHarold added the ok-to-merge PRs should be labelled with this before merging label Nov 16, 2022
@randomvariable randomvariable merged commit 802af8c into main Nov 16, 2022
@randomvariable randomvariable deleted the topic/fhan/oracle-cpi-init branch November 16, 2022 13:11
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@XudongLiuHarold XudongLiuHarold XudongLiuHarold approved these changes

Assignees
No one assigned
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HanFa @randomvariable @XudongLiuHarold @vmwclabot