Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Remove obsolete management components #3900

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Remove obsolete management components #3900

merged 3 commits into from
Nov 17, 2022

Conversation

imikushin
Copy link
Contributor

@imikushin imikushin commented Nov 11, 2022

Remove obsolete management components when upgrading the management cluster. Currently, it's the old tkr-controller-manager deployment in the tkr-system namespace.

Signed-off-by: Ivan Mikushin imikushin@vmware.com

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #3887

Describe testing done for PR

Added a unit test.

Release note

When upgrading the management cluster to new TKG version, obsolete management components (currently, the tkr-controller-manager deployment in the tkr-system namespace) will be deleted prior to installing the new management packages.

Additional information

Special notes for your reviewer

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3900/20221111033119/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #3900 (9ff465b) into main (7f8c8f7) will decrease coverage by 0.92%.
The diff coverage is 38.15%.

❗ Current head 9ff465b differs from pull request most recent head 5e66f67. Consider uploading reports for the commit 5e66f67 to get more accurate results

@@            Coverage Diff             @@
##             main    #3900      +/-   ##
==========================================
- Coverage   46.95%   46.03%   -0.93%     
==========================================
  Files         403      427      +24     
  Lines       40314    41836    +1522     
==========================================
+ Hits        18929    19258     +329     
- Misses      19628    20805    +1177     
- Partials     1757     1773      +16     
Impacted Files Coverage Δ
tkg/client/delete_region.go 0.00% <0.00%> (ø)
tkg/client/init.go 0.00% <0.00%> (ø)
tkg/client/upgrade_region.go 24.93% <0.00%> (-0.26%) ⬇️
...nagementcomponents/management_component_install.go 76.69% <0.00%> (+2.23%) ⬆️
tkg/client/management_components.go 21.59% <63.04%> (+9.62%) ⬆️
tkg/managementcomponents/helper.go 94.11% <0.00%> (-0.85%) ⬇️
tkg/tkgconfigbom/bom_types.go 0.00% <0.00%> (ø)
tkg/client/cleanup_core_repo.go
cmd/cli/plugin/cluster/upgrade.go 58.50% <0.00%> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Ivan Mikushin added 2 commits November 14, 2022 16:10
Remove obsolete management components when upgrading the management
cluster. Currently, it's the old tkr-controller-manager deployment in
the tkr-system namespace.

Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3900/20221115020941/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@imikushin imikushin added ok-to-merge PRs should be labelled with this before merging area/tkr not-core-cli labels Nov 15, 2022
# Conflicts:
#	tkg/client/management_components.go
#	tkg/client/management_components_test.go
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3900/20221116193239/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Contributor

@prkalle prkalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Copy link
Contributor

@tenczar tenczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wjun wjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@12345lcr 12345lcr merged commit 3973e50 into main Nov 17, 2022
@12345lcr 12345lcr deleted the tf-3887 branch November 17, 2022 10:14
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area/tkr cla-not-required not-core-cli ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old tkr-source-controller needs to be removed when upgrading to (u)TKG 2.0
6 participants