-
Notifications
You must be signed in to change notification settings - Fork 192
Remove obsolete management components #3900
Conversation
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #3900 +/- ##
==========================================
- Coverage 46.95% 46.03% -0.93%
==========================================
Files 403 427 +24
Lines 40314 41836 +1522
==========================================
+ Hits 18929 19258 +329
- Misses 19628 20805 +1177
- Partials 1757 1773 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Remove obsolete management components when upgrading the management cluster. Currently, it's the old tkr-controller-manager deployment in the tkr-system namespace. Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
Cluster Generation A/B Results: |
# Conflicts: # tkg/client/management_components.go # tkg/client/management_components_test.go
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove obsolete management components when upgrading the management cluster. Currently, it's the old tkr-controller-manager deployment in the tkr-system namespace.
Signed-off-by: Ivan Mikushin imikushin@vmware.com
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #3887
Describe testing done for PR
Added a unit test.
Release note
Additional information
Special notes for your reviewer