This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Add logic for clusterboostrap webhook to handle deleting cluster #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a cluster is being deleted is possible that some of the objects the clusterbootstrap webhook is looking for might be deleted by the time the webhook checks for them. In that case the validation should not fail because the cluster is being deleted. fixes: 3931
Codecov Report
@@ Coverage Diff @@
## main #3932 +/- ##
==========================================
- Coverage 46.95% 46.50% -0.46%
==========================================
Files 403 445 +42
Lines 40314 43259 +2945
==========================================
+ Hits 18929 20117 +1188
- Misses 19628 21214 +1586
- Partials 1757 1928 +171
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@adduarte Thanks for the PR. Please add release note:) |
maralavi
approved these changes
Nov 17, 2022
|
@adduarte Could you please check if its possible to add unit test for this ? Thanks |
This was referenced Jan 19, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a cluster is being deleted is possible that some of the objects the clusterbootstrap webhook is looking for might be deleted by the time the webhook checks for them.
In that case the validation should not fail because the cluster is being deleted.
fixes: #3931
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes # 3931
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer