-
Notifications
You must be signed in to change notification settings - Fork 192
Conversation
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #3947 +/- ##
==========================================
- Coverage 47.72% 46.78% -0.95%
==========================================
Files 420 445 +25
Lines 41985 43574 +1589
==========================================
+ Hits 20037 20384 +347
- Misses 20037 21260 +1223
- Partials 1911 1930 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix lint errors and make sure CI is green. You might want to rebase on latest where CAPD tests are disabled.
88b15a6
to
7b7e42a
Compare
@rajathagasthya -- I believe the linter is not failing because of my PR. Let me know if you think otherwise. Anyways, I have rebased and pushed. |
Will see if the lint fails again and figure out the problem. |
Cluster Generation A/B Results: |
I see the yamllint problem -- may be I missed seeing that. My bad. |
Signed-off-by: Ashutosh Kumar <sonasingh46@gmail.com>
7b7e42a
to
10c1cc0
Compare
Cluster Generation A/B Results: |
Signed-off-by: Ashutosh Kumar sonasingh46@gmail.com
What this PR does / why we need it
Add tolerations to aad-pod-identity component YAML.
CAPZ pods has control plane tolerations and this means that capz pod can get scheduled to control plane nodes. The aad-pod-identity does not have tolerations which can cause authentication issue if the capz pod gets scheduled to a ctonrol plane node.
This PR adds control plane tolerations to aad pod identity so that the their pods can be scheduled to control plane nodes too.
Which issue(s) this PR fixes
Fixes #3946
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer
Tested this PR by building the cli binary and creating a bootstrap cluster. Observed that the capz-nmi DaemonSet has the required tolerations.