-
Notifications
You must be signed in to change notification settings - Fork 192
Fix upgrade check to allow upgrades to 2.x.x #3990
Conversation
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #3990 +/- ##
==========================================
- Coverage 48.22% 47.36% -0.87%
==========================================
Files 433 456 +23
Lines 43122 44597 +1475
==========================================
+ Hits 20795 21122 +327
- Misses 20343 21469 +1126
- Partials 1984 2006 +22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This change updates are upgrade validation logic to allow users to upgrade from 1.6.x to 2.x.x. It will return an error if a user attempts to upgrade from a version less than 1.6 or if they try to upgrade to major version 3. Obviously that check will need to be updated on release of major version 3.
6af682b
to
c0f742c
Compare
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change updates are upgrade validation logic to allow users to upgrade from 1.6.x to 2.x.x. It will return an error if a user attempts to upgrade from a version less than 1.6 or if they try to upgrade to major version 3. Obviously that check will need to be updated on release of major version 3.
What this PR does / why we need it
This fix allows us to move to TKG with major version 2. A previous check would throw an error if the major version was changed.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Updated unit tests to include validation that upgrades to major version 3 still throw an error. Also added test to make sure an error is thrown when upgrade to v2 from a version less than v1.6
Release note
Additional information
Special notes for your reviewer