-
Notifications
You must be signed in to change notification settings - Fork 192
Conversation
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #4033 +/- ##
==========================================
- Coverage 48.15% 47.35% -0.80%
==========================================
Files 433 456 +23
Lines 43136 44595 +1459
==========================================
+ Hits 20772 21118 +346
- Misses 20373 21470 +1097
- Partials 1991 2007 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Add Cluster variable etcdExtraArgs to set arbitrary etcd flags. Add Cluster variable tlsCipherSuites to store the default cipher suites. When etcdExtraArgs does not contain cipher-suites, the default value is set. Add variable ETCD_EXTRA_ARGS for UX backward compatibility.
8123ab2
to
0b0d8f2
Compare
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems reasonable to me. I'm becoming a little concerned with how much customization is being baked directly into every clusterclass. I think podsecuritypolicy added clusterclass customizations in an interesting way, or maybe we even adopt kustomize in the future...
@tenczar @wjun As you can see jsonpatch is aweful, other folks can introduce a patch to change the same fields by accident and there is no way to write unit test to ensure the expected behavior. We should try runtime sdk next release so we can easily modify map, array and leverage unit tests to avoid regression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add Cluster variable etcdExtraArgs to set arbitrary etcd flags. Add Cluster variable tlsCipherSuites to store the default cipher suites. When etcdExtraArgs does not contain cipher-suites, the default value is set.
Add variable ETCD_EXTRA_ARGS for UX backward compatibility.
What this PR does / why we need it
We need to support configuring etcd flags since Nimbus testbeds have only low performance storages.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer