Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Translate FQDN ytt template to ClusterClass json patch #4064

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

chenlin07
Copy link
Contributor

@chenlin07 chenlin07 commented Dec 1, 2022

Signed-off-by: Chen Lin linch@vmware.com

What this PR does / why we need it

Previously, we support this using ytt template. In order to support upgrade from non classy to classy cluster in the future, we need to support same functionality using json patch
https://docs.vmware.com/en/VMware-Tanzu-Kubernetes-Grid/1.6/vmware-tanzu-kubernetes-grid-16/GUID-tanzu-k8s-clusters-config-plans.html#fqdn-control-plane-endpoint-with-nsx-alb-5

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

install-vc7 pipeline and manual validation following:
https://docs.vmware.com/en/VMware-Tanzu-Kubernetes-Grid/1.6/vmware-tanzu-kubernetes-grid-16/GUID-tanzu-k8s-clusters-networking.html?hWord=N4IghgNiBcIMYCcCmYAuSAEATAdgZwzA2TgHsEsQBfIA

Release note

 Support FQDN Control Plane Endpoint with NSX ALB in Cluster Class

Additional information

Special notes for your reviewer

@chenlin07 chenlin07 requested review from a team as code owners December 1, 2022 07:57
@chenlin07 chenlin07 changed the title Translate FQDN ytt template to ClusterClass json patch [DO NOT MERGE]Translate FQDN ytt template to ClusterClass json patch Dec 1, 2022
@chenlin07 chenlin07 force-pushed the topic/chenlin/json-patch-fqdn branch from f2e6699 to cb62ebb Compare December 1, 2022 09:06
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4064/20221201091648/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@chenlin07 chenlin07 force-pushed the topic/chenlin/json-patch-fqdn branch from cb62ebb to a2b939a Compare December 1, 2022 13:58
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4064/20221201140739/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #4064 (4902059) into main (a334b86) will decrease coverage by 0.79%.
The diff coverage is n/a.

❗ Current head 4902059 differs from pull request most recent head f0bb001. Consider uploading reports for the commit f0bb001 to get more accurate results

@@            Coverage Diff             @@
##             main    #4064      +/-   ##
==========================================
- Coverage   48.52%   47.73%   -0.80%     
==========================================
  Files         446      469      +23     
  Lines       44105    45574    +1469     
==========================================
+ Hits        21404    21756     +352     
- Misses      20658    21756    +1098     
- Partials     2043     2062      +19     
Impacted Files Coverage Δ
addons/controllers/machine_controller.go 65.65% <0.00%> (-3.04%) ⬇️
packageclients/pkg/packageclient/package_update.go 83.57% <0.00%> (-1.43%) ⬇️
cmd/cli/plugin/cluster/upgrade.go 58.94% <0.00%> (ø)
cmd/cli/plugin/cluster/list.go 11.36% <0.00%> (ø)
cmd/cli/plugin/cluster/available_upgrade.go 16.32% <0.00%> (ø)
cmd/cli/plugin/cluster/delete.go 12.50% <0.00%> (ø)
cmd/cli/plugin/cluster/get_node_pools.go 10.52% <0.00%> (ø)
...in/cluster/set_machinehealthcheck_control_plane.go 21.21% <0.00%> (ø)
cmd/cli/plugin/cluster/get.go 6.27% <0.00%> (ø)
cmd/cli/plugin/cluster/delete_node_pool.go 16.66% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lubronzhan lubronzhan added the ok-to-merge PRs should be labelled with this before merging label Dec 2, 2022
@chenlin07 chenlin07 force-pushed the topic/chenlin/json-patch-fqdn branch from a2b939a to 0379af0 Compare December 2, 2022 02:46
Signed-off-by: Chen Lin <linch@vmware.com>
@chenlin07 chenlin07 force-pushed the topic/chenlin/json-patch-fqdn branch from 0379af0 to 233e687 Compare December 6, 2022 08:01
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4064/20221206081927/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@chenlin07
Copy link
Contributor Author

/test install-v7

@chenlin07 chenlin07 force-pushed the topic/chenlin/json-patch-fqdn branch from 2d452fe to 4902059 Compare December 7, 2022 02:49
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4064/20221207030002/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@chenlin07
Copy link
Contributor Author

/test install-v7

@alfredthenarwhal
Copy link
Collaborator

@chenlin07: /test install-v7
Commit: 4902059

Tests failed! Build no: 3489

@chenlin07 chenlin07 force-pushed the topic/chenlin/json-patch-fqdn branch from 4902059 to f0bb001 Compare December 7, 2022 08:39
@chenlin07 chenlin07 changed the title [DO NOT MERGE]Translate FQDN ytt template to ClusterClass json patch Translate FQDN ytt template to ClusterClass json patch Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4064/20221207084810/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@chenlin07 chenlin07 merged commit abab978 into main Dec 7, 2022
@chenlin07 chenlin07 deleted the topic/chenlin/json-patch-fqdn branch December 7, 2022 08:56
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants