You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenlin07
changed the title
Translate FQDN ytt template to ClusterClass json patch
[DO NOT MERGE]Translate FQDN ytt template to ClusterClass json patch
Dec 1, 2022
Merging #4064 (4902059) into main (a334b86) will decrease coverage by 0.79%.
The diff coverage is n/a.
❗ Current head 4902059 differs from pull request most recent head f0bb001. Consider uploading reports for the commit f0bb001 to get more accurate results
chenlin07
changed the title
[DO NOT MERGE]Translate FQDN ytt template to ClusterClass json patch
Translate FQDN ytt template to ClusterClass json patch
Dec 7, 2022
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chen Lin linch@vmware.com
What this PR does / why we need it
Previously, we support this using ytt template. In order to support upgrade from non classy to classy cluster in the future, we need to support same functionality using json patch
https://docs.vmware.com/en/VMware-Tanzu-Kubernetes-Grid/1.6/vmware-tanzu-kubernetes-grid-16/GUID-tanzu-k8s-clusters-config-plans.html#fqdn-control-plane-endpoint-with-nsx-alb-5
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
install-vc7 pipeline and manual validation following:
https://docs.vmware.com/en/VMware-Tanzu-Kubernetes-Grid/1.6/vmware-tanzu-kubernetes-grid-16/GUID-tanzu-k8s-clusters-networking.html?hWord=N4IghgNiBcIMYCcCmYAuSAEATAdgZwzA2TgHsEsQBfIA
Release note
Additional information
Special notes for your reviewer