Rename kctrl-command-tree feature flag

[praveenrewar]

What this PR does / why we need it

Rename kctrl-command-tree feature flag.
Use features.package.kctrl-command-tree instead of features.package.kctrl-package-command-tree. This is done to ensure that the default value is toggled to true even while upgrading from an older version.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

`tanzu config set features.package.kctrl-command-tree false` can be used to turn off kctrl command tree.

[codecov]

Codecov Report

Merging #4162 (e7ca634) into main (f005d62) will decrease coverage by 0.94%.
The diff coverage is n/a.

❗ Current head e7ca634 differs from pull request most recent head 09d491f. Consider uploading reports for the commit 09d491f to get more accurate results

@@            Coverage Diff             @@
##             main    #4162      +/-   ##
==========================================
- Coverage   49.31%   48.37%   -0.95%     
==========================================
  Files         450      480      +30     
  Lines       44577    46697    +2120     
==========================================
+ Hits        21984    22588     +604     
- Misses      20519    21977    +1458     
- Partials     2074     2132      +58     

Impacted Files	Coverage Δ
addons/controllers/clusterbootstrap_controller.go	64.84% <0.00%> (-1.56%)	⬇️
packageclients/pkg/packageclient/package_update.go	83.57% <0.00%> (-1.43%)	⬇️
...ons/controllers/packageinstallstatus_controller.go	77.99% <0.00%> (-1.16%)	⬇️
tkg/client/common.go	41.82% <0.00%> (-0.44%)	⬇️
cmd/cli/plugin/cluster/get_machinehealthcheck.go	11.42% <0.00%> (ø)
cmd/cli/plugin/cluster/credentials_update.go	8.73% <0.00%> (ø)
...li/plugin/isolated-cluster/imgpkginterface/util.go	50.00% <0.00%> (ø)
cmd/cli/plugin/cluster/delete_node_pool.go	16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/set_machinehealthcheck.go	23.33% <0.00%> (ø)
cmd/cli/plugin/cluster/get.go	6.27% <0.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[marckhouzam]

This looks ok to me.
But we may want to update the string kctrl-package-command-tree in the test of cmd/cli/plugin/package/test/package_plugin_integration_test.go.

[praveenrewar]

But we may want to update the string kctrl-package-command-tree in the test of cmd/cli/plugin/package/test/package_plugin_integration_test.go.

Good catch! Thanks :)
Not that it matters but I am thinking of updating the usage in cli/runtime/config/config_factory_test.go as well.

[marckhouzam]

Good catch! Thanks :) Not that it matters but I am thinking of updating the usage in cli/runtime/config/config_factory_test.go as well.

Sounds like a good idea. Thanks for doing that! 👍