This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Fix package plugin tests for classy clusters #4192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fix package plugin tests for classy clusters. Classy clusters use packageInstall CR on management cluster for installing kapp-controller on workload cluster. Legacy clusters use App CR on management cluster for installing kapp-controller on workload cluster. In the test we were pausing App before patching kapp-controller configmap but in Classy clusters this was getting overridden since PackageInstall CR is not paused. This change makes sure to check if packageinstall is found then pause packageinstall else pause app.
Which issue(s) this PR fixes
Fixes #4209
Describe testing done for PR
Ran the test on a classy and legacy cluster and it passes
Release note
Additional information
Special notes for your reviewer