Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Fix package plugin tests for classy clusters #4192

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

shyaamsn
Copy link
Contributor

@shyaamsn shyaamsn commented Dec 18, 2022

What this PR does / why we need it

Fix package plugin tests for classy clusters. Classy clusters use packageInstall CR on management cluster for installing kapp-controller on workload cluster. Legacy clusters use App CR on management cluster for installing kapp-controller on workload cluster. In the test we were pausing App before patching kapp-controller configmap but in Classy clusters this was getting overridden since PackageInstall CR is not paused. This change makes sure to check if packageinstall is found then pause packageinstall else pause app.

Which issue(s) this PR fixes

Fixes #4209

Describe testing done for PR

Ran the test on a classy and legacy cluster and it passes

Release note

Fix package plugin tests for classy clusters

Additional information

Special notes for your reviewer

@shyaamsn shyaamsn requested review from a team as code owners December 18, 2022 18:03
@shyaamsn shyaamsn force-pushed the topic/fix_package_plugin_tests branch from ac36860 to 6d775ad Compare December 18, 2022 18:57
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Merging #4192 (27f2e6c) into main (6b5fb26) will decrease coverage by 0.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4192      +/-   ##
==========================================
- Coverage   49.27%   48.42%   -0.85%     
==========================================
  Files         450      480      +30     
  Lines       44575    46697    +2122     
==========================================
+ Hits        21963    22612     +649     
- Misses      20533    21960    +1427     
- Partials     2079     2125      +46     
Impacted Files Coverage Δ
cmd/cli/plugin/cluster/set_node_pool.go 14.63% <0.00%> (ø)
cmd/cli/plugin/cluster/available_upgrade.go 16.32% <0.00%> (ø)
cmd/cli/plugin/cluster/get_machinehealthcheck.go 11.42% <0.00%> (ø)
cmd/cli/plugin/cluster/list.go 11.36% <0.00%> (ø)
cmd/cli/plugin/cluster/credentials_update.go 8.73% <0.00%> (ø)
...i/plugin/cluster/delete_machinehealthcheck_node.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/upgrade.go 58.94% <0.00%> (ø)
...in/cluster/get_machinehealthcheck_control_plane.go 11.11% <0.00%> (ø)
cmd/cli/plugin/cluster/set_machinehealthcheck.go 23.33% <0.00%> (ø)
...in/cluster/set_machinehealthcheck_control_plane.go 21.21% <0.00%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shyaamsn shyaamsn force-pushed the topic/fix_package_plugin_tests branch 3 times, most recently from 9e207f0 to d7eccf9 Compare December 19, 2022 13:43
@shyaamsn shyaamsn force-pushed the topic/fix_package_plugin_tests branch from d7eccf9 to 2b0356a Compare December 20, 2022 07:51
@shyaamsn shyaamsn force-pushed the topic/fix_package_plugin_tests branch 3 times, most recently from 629c0e1 to 7296b97 Compare December 21, 2022 19:47
@shyaamsn shyaamsn force-pushed the topic/fix_package_plugin_tests branch from 7296b97 to 27f2e6c Compare December 21, 2022 20:33
@rajathagasthya rajathagasthya added the ok-to-merge PRs should be labelled with this before merging label Dec 21, 2022
@shyaamsn shyaamsn merged commit 95e2461 into main Dec 21, 2022
@shyaamsn shyaamsn deleted the topic/fix_package_plugin_tests branch December 21, 2022 21:55
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package plugin integration test fails with Calico CNI
5 participants