Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Package Plugin Tests: Wait for App to be paused before updating kapp-controller configmap #4223

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

shyaamsn
Copy link
Contributor

@shyaamsn shyaamsn commented Jan 3, 2023

What this PR does / why we need it

Package Plugin Tests: Wait for App to be paused before updating kapp-controller configmap.

There is a race condition that sometimes App is not paused and kapp-controller configmap changes are reverted. Hence we are waiting for App to be paused to avoid this race condition.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Tested package plugin tests on classy clusters. Legacy cluster tests would be part of github pipeline testing

Release note

Package Plugin Tests: Wait for App to be paused before updating kapp-controller configmap.

Additional information

Special notes for your reviewer

@shyaamsn shyaamsn requested review from a team as code owners January 3, 2023 18:25
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #4223 (ac9cf31) into main (df0d0b3) will decrease coverage by 0.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4223      +/-   ##
==========================================
- Coverage   49.28%   48.39%   -0.89%     
==========================================
  Files         451      481      +30     
  Lines       44602    46724    +2122     
==========================================
+ Hits        21982    22612     +630     
- Misses      20540    21981    +1441     
- Partials     2080     2131      +51     
Impacted Files Coverage Δ
packageclients/pkg/packageclient/package_update.go 83.57% <0.00%> (-1.43%) ⬇️
cmd/cli/plugin/tkr/v1alpha3/os.go 73.50% <0.00%> (-0.86%) ⬇️
cmd/cli/plugin/cluster/machinehealthcheck.go 100.00% <0.00%> (ø)
...cluster/delete_machinehealthcheck_control_plane.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/set_node_pool.go 14.63% <0.00%> (ø)
cmd/cli/plugin/cluster/scale.go 17.85% <0.00%> (ø)
cmd/cli/plugin/cluster/create.go 42.22% <0.00%> (ø)
...olated-cluster/imagepushop/publishimagesfromtar.go 73.17% <0.00%> (ø)
cmd/cli/plugin/isolated-cluster/test/main.go 0.00% <0.00%> (ø)
cmd/cli/plugin/cluster/delete.go 12.50% <0.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shyaamsn shyaamsn force-pushed the topic/fix_package_plugin_tests branch from c20f3fa to ac9cf31 Compare January 4, 2023 00:31
@shyaamsn shyaamsn added the ok-to-merge PRs should be labelled with this before merging label Jan 4, 2023
@shyaamsn shyaamsn merged commit 0ac8bdc into main Jan 4, 2023
@shyaamsn shyaamsn deleted the topic/fix_package_plugin_tests branch January 4, 2023 04:02
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants