Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Kickstart UI: remove AWS option for new VPC creation #4224

Merged

Conversation

miclettej
Copy link
Contributor

Due to CAPA bump, new VPC creation is no longer supported in the CLI. This PR removes the option to create a new VPC from the UI as well.

User is no longer presented with an option to choose between use existing/new; instead they are only presented with form controls for using an existing VPC.

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

When creating a management cluster on AWS through the Installer Interface (kickstart UI), new VPC creation is no longer supported. User must follow steps to select an existing VPC. This is a result of a CAPA bump that inhibits new VPC creation by the CLI and therefore also the UI.

Additional information

Special notes for your reviewer

Screen Shot 2023-01-03 at 11 34 01 AM

Due to CAPA bump, new VPC creation is no longer supported in the CLI. This PR removes the option to create a new VPC from the UI as well.

User is no longer presented with an option to choose between use existing/new; instead they are only presented with form controls for using an existing VPC.
@miclettej miclettej requested review from a team as code owners January 3, 2023 19:38
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4224/20230103194603/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@miclettej miclettej added area/ui Specific UI issue/enhancement ok-to-merge PRs should be labelled with this before merging labels Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4224/20230103200949/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4224/20230103203219/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #4224 (38518ca) into main (6652c70) will decrease coverage by 0.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4224      +/-   ##
==========================================
- Coverage   49.31%   48.43%   -0.89%     
==========================================
  Files         451      481      +30     
  Lines       44602    46724    +2122     
==========================================
+ Hits        21996    22631     +635     
- Misses      20530    21967    +1437     
- Partials     2076     2126      +50     
Impacted Files Coverage Δ
...oller-manager/controllers/v3_cascade_controller.go 66.66% <0.00%> (-10.00%) ⬇️
packageclients/pkg/packageclient/package_update.go 83.57% <0.00%> (-1.43%) ⬇️
cmd/cli/plugin/cluster/available_upgrade.go 16.32% <0.00%> (ø)
.../isolated-cluster/imgpkginterface/client_imgpkg.go 0.00% <0.00%> (ø)
cmd/cli/plugin/cluster/scale.go 17.85% <0.00%> (ø)
cmd/cli/plugin/cluster/machinehealthcheck.go 100.00% <0.00%> (ø)
cmd/cli/plugin/cluster/set_node_pool.go 14.63% <0.00%> (ø)
...olated-cluster/imagepushop/publishimagesfromtar.go 73.17% <0.00%> (ø)
...li/plugin/isolated-cluster/imgpkginterface/util.go 50.00% <0.00%> (ø)
cmd/cli/plugin/cluster/delete.go 12.50% <0.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@miclettej miclettej merged commit 19b6e29 into vmware-tanzu:main Jan 4, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area/ui Specific UI issue/enhancement cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants