Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Skip CLIPlugin CRD installation as part of core-management-plugins package #4232

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented Jan 4, 2023

What this PR does / why we need it

It was observed that cliplugins package reconciliation fails because of the race condition on installing CLIPlugins CRD by cliplugin and core-management-plugins packages.

  • core-management-plugins package should not install the CRD if it is getting deployed through TKG composite package.

Currently, the values.yaml file of the TKG composite package specifies deployCLIPluginCRD: false however, the same thing is not configured programmatically and hence the core-management-plugins package is also trying to deploy that CRD. This PR fixes that logic.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Skip CLIPlugin CRD installation as part of core-management-plugins package

Additional information

Special notes for your reviewer

@anujc25 anujc25 requested review from a team as code owners January 4, 2023 20:29
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4232/20230104203811/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable
Copy link
Contributor

Thanks

@randomvariable randomvariable added the ok-to-merge PRs should be labelled with this before merging label Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #4232 (95a20b9) into main (19b6e29) will decrease coverage by 0.89%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4232      +/-   ##
==========================================
- Coverage   49.34%   48.44%   -0.90%     
==========================================
  Files         451      481      +30     
  Lines       44627    46781    +2154     
==========================================
+ Hits        22022    22665     +643     
- Misses      20531    21985    +1454     
- Partials     2074     2131      +57     
Impacted Files Coverage Δ
tkg/managementcomponents/helper.go 92.00% <100.00%> (-1.64%) ⬇️
addons/controllers/clusterbootstrap_controller.go 64.84% <0.00%> (-1.56%) ⬇️
...ons/controllers/packageinstallstatus_controller.go 77.99% <0.00%> (-1.16%) ⬇️
cmd/cli/plugin/cluster/set_machinehealthcheck.go 23.33% <0.00%> (ø)
cmd/cli/plugin/cluster/delete.go 12.50% <0.00%> (ø)
cmd/cli/plugin/cluster/create.go 42.22% <0.00%> (ø)
...in/cluster/get_machinehealthcheck_control_plane.go 11.11% <0.00%> (ø)
cmd/cli/plugin/cluster/credentials_update.go 8.73% <0.00%> (ø)
cmd/cli/plugin/cluster/machinehealthcheck.go 100.00% <0.00%> (ø)
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anujc25 anujc25 merged commit 523e579 into main Jan 5, 2023
@anujc25 anujc25 deleted the anujc/fix-race-condition-cliplugins-package branch January 5, 2023 14:12
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants