This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Skip CLIPlugin CRD installation as part of core-management-plugins package #4232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
It was observed that
cliplugins
package reconciliation fails because of the race condition on installing CLIPlugins CRD bycliplugin
andcore-management-plugins
packages.core-management-plugins
package should not install the CRD if it is getting deployed through TKG composite package.Currently, the
values.yaml
file of the TKG composite package specifiesdeployCLIPluginCRD: false
however, the same thing is not configured programmatically and hence thecore-management-plugins
package is also trying to deploy that CRD. This PR fixes that logic.Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer