Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Fixup for EventRate limiting for Docker ClusterClass #4260

Conversation

randomvariable
Copy link
Contributor

#4128 was missing a file

Signed-off-by: Naadir Jeewa jeewan@vmware.com

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note


Additional information

Special notes for your reviewer

Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@randomvariable randomvariable requested a review from a team as a code owner January 9, 2023 17:22
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #4260 (66909c2) into main (d293a08) will decrease coverage by 0.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4260      +/-   ##
==========================================
- Coverage   49.40%   48.53%   -0.87%     
==========================================
  Files         451      481      +30     
  Lines       44749    46869    +2120     
==========================================
+ Hits        22110    22750     +640     
- Misses      20554    21986    +1432     
- Partials     2085     2133      +48     
Impacted Files Coverage Δ
addons/controllers/machine_controller.go 65.65% <0.00%> (-3.04%) ⬇️
cmd/cli/plugin/cluster/machinehealthcheck.go 100.00% <0.00%> (ø)
.../cli/plugin/cluster/get_machinehealthcheck_node.go 9.30% <0.00%> (ø)
cmd/cli/plugin/cluster/set_machinehealthcheck.go 23.33% <0.00%> (ø)
...isolated-cluster/imagepullop/publishimagestotar.go 61.36% <0.00%> (ø)
...cluster/delete_machinehealthcheck_control_plane.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/get_machinehealthcheck.go 11.42% <0.00%> (ø)
...i/plugin/cluster/delete_machinehealthcheck_node.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/scale.go 17.85% <0.00%> (ø)
cmd/cli/plugin/isolated-cluster/test/main.go 0.00% <0.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@randomvariable
Copy link
Contributor Author

Turns out I already did it in #4255

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants