This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
TKR Resolver: exact TKR version match (if exists) should be the only result #4271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
When the exact TKR version is specified as the version prefix AND such TKR exists, it should be the only result in the returned resolution result set.
This fixes a problem, where there are TKRs whose versions are longer than the provided exactly matching TKR version.
For example, the provided prefix is
v1.22.13+vmware.1-tkg.1
. There are two TKRs with versions satisfying this version prefix:v1.22.13+vmware.1-tkg.1
,v1.22.13+vmware.1-tkg.1-zshippable
.Of the above two,
v1.22.13+vmware.1-tkg.1
must be used, because it is the exact match, and is least surprising for the user specifyingv1.22.13+vmware.1-tkg.1
as the version prefix.Which issue(s) this PR fixes
Fixes #4262
Describe testing done for PR
Updated unit tests with the test case exposing the issue.
Release note
Additional information
Special notes for your reviewer