-
Notifications
You must be signed in to change notification settings - Fork 192
fix issue with querying for GVR in capabilities discovery package #4272
fix issue with querying for GVR in capabilities discovery package #4272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding this bug and fixing it so quickly, @yharish991.
3e9a054
to
15ae8bc
Compare
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #4272 +/- ##
==========================================
- Coverage 49.40% 48.50% -0.91%
==========================================
Files 451 481 +30
Lines 44755 46878 +2123
==========================================
+ Hits 22111 22737 +626
- Misses 20560 22004 +1444
- Partials 2084 2137 +53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
15ae8bc
to
850e5f2
Compare
This commit addresses the issue with querying for GVR without version, resourceListInGroup previously returns the resources whenever it finds the match for group name, but instead it should aggregate the resources of all the versions in that group and return the results.
850e5f2
to
87d3b83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes lgtm, adding my approval. (But we still need to cleanup before merge)
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Please add some tests in a follow up PR.
What this PR does / why we need it
When querying for existence of GVR without version, capabilities discovery package returns false even though the resource exists. This PR is for fixing that issue.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Verified that the units tests are passing and wrote a small sample program to test GVR query functionality
Release note
Additional information
Special notes for your reviewer