This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Fix vSphere OSImage labeling #4282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For vsphere-nonparavirt provider, OSImage objects have version field
their `.spec.image.ref` field, e.g. like this:
```
image:
type: ova
ref:
version: v1.24.9+vmware.1-tkg.1-226b7a84930e5368c38aa867f998ce33
```
When being added to the TKR Resolver cache (for example, when being
updated by the tkr-status-controller), the OSImage `.spec.image.ref`
contents are set as the OSImage labels to enable resolution of the
OSImage by this data using a label query.
The problem is: "+" cannot be used in label values. This change fixes it
by replacing "+" with "---" (same way we derive TKR names from their
versions).
Signed-off-by: Ivan Mikushin <imikushin@vmware.com>
|
/test install-vc7 |
Codecov Report
@@ Coverage Diff @@
## main #4282 +/- ##
==========================================
- Coverage 49.41% 48.51% -0.91%
==========================================
Files 451 481 +30
Lines 44718 46869 +2151
==========================================
+ Hits 22098 22739 +641
- Misses 20541 21994 +1453
- Partials 2079 2136 +57
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/lgtm |
miclettej
approved these changes
Jan 14, 2023
imikushin
deleted the
topic/imikushin/vsphere-osimage-ref-version-label
branch
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
For vsphere-nonparavirt provider, OSImage objects have version field their
.spec.image.reffield, e.g. like this:When being added to the TKR Resolver cache (for example, when being updated by the tkr-status-controller), the OSImage
.spec.image.refcontents are set as the OSImage labels to enable resolution of the OSImage by this data using a label query.The problem is: "+" cannot be used in label values. This change fixes it by replacing "+" with "---" (same way we derive TKR names from their versions).
Which issue(s) this PR fixes
N/A
Describe testing done for PR
Updated unit tests to expose the problem fixed.
Release note
Additional information
Special notes for your reviewer