Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

skip reconciliation for azure csi config temaplates #4439

Closed
wants to merge 1 commit into from

Conversation

adduarte
Copy link

azure csi configs annotated as templates should skip reconciliation.

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #4435

Describe testing done for PR

Release note


Additional information

Special notes for your reviewer

azure csi configs annotated as templates should skip reconciliation.
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #4439 (822d909) into main (e982ed1) will decrease coverage by 0.91%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4439      +/-   ##
==========================================
- Coverage   49.67%   48.76%   -0.91%     
==========================================
  Files         452      482      +30     
  Lines       45055    47175    +2120     
==========================================
+ Hits        22379    23005     +626     
- Misses      20560    22002    +1442     
- Partials     2116     2168      +52     
Impacted Files Coverage Δ
packageclients/pkg/packageclient/package_update.go 83.57% <0.00%> (-1.43%) ⬇️
...md/cli/plugin/cluster/delete_machinehealthcheck.go 19.23% <0.00%> (ø)
cmd/cli/plugin/cluster/delete.go 12.50% <0.00%> (ø)
cmd/cli/plugin/cluster/delete_node_pool.go 16.66% <0.00%> (ø)
cmd/cli/plugin/isolated-cluster/test/main.go 0.00% <0.00%> (ø)
cmd/cli/plugin/cluster/get_node_pools.go 10.52% <0.00%> (ø)
cmd/cli/plugin/cluster/create.go 42.22% <0.00%> (ø)
cmd/cli/plugin/cluster/main.go 0.00% <0.00%> (ø)
.../cli/plugin/cluster/get_machinehealthcheck_node.go 9.30% <0.00%> (ø)
cmd/cli/plugin/cluster/scale.go 17.85% <0.00%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adduarte adduarte closed this Mar 15, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vspherecsi_controller.go incorrectly attempts to reconcile TKG-system template pods
2 participants