This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Add VolumeSnapshot related RBACs to provider service account for TKC/GC #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akankshapanse
force-pushed
the
add_snapshot_rbac
branch
from
3ae2943 to
c4f7be0
Compare
Codecov Report
@@ Coverage Diff @@
## main #4491 +/- ##
==========================================
- Coverage 49.70% 48.78% -0.93%
==========================================
Files 452 482 +30
Lines 45152 47272 +2120
==========================================
+ Hits 22445 23061 +616
- Misses 20582 22032 +1450
- Partials 2125 2179 +54
... and 34 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
akankshapanse
changed the title
wjun
approved these changes
Mar 23, 2023
|
/test install-vc7 |
Tests failed! Build no: 4550 |
m1zzx2
pushed a commit
that referenced
this pull request
Mar 27, 2023
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR adds RBAC rules for volume snapshot objects to provider service account when CSI controller is running in paravirtual mode. That provides the guest cluster with all the permissions to operate volume snapshot objects.
This is being done for adding snapshot support in WCP.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer