Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

enhance output instuction when creating cc cluster with legacy config #4511

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

hongtaiwang
Copy link
Contributor

@hongtaiwang hongtaiwang commented Mar 22, 2023

What this PR does / why we need it

When creating cluster using cluster yaml, the validation does not read configurations from the yaml context. So if none custom flags are explicitly set in this step, tanzu cli will validate with defualt value

ALL customized flags are required to set when creating cluster with a cc cluster yaml.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note


Additional information

Special notes for your reviewer

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4511/20230322073912/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #4511 (8c1df7e) into main (893310a) will decrease coverage by 0.94%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4511      +/-   ##
==========================================
- Coverage   49.87%   48.94%   -0.94%     
==========================================
  Files         453      483      +30     
  Lines       45405    47525    +2120     
==========================================
+ Hits        22647    23260     +613     
- Misses      20612    22064    +1452     
- Partials     2146     2201      +55     
Impacted Files Coverage Δ
tkg/client/cluster.go 35.86% <100.00%> (ø)

... and 35 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tkg/client/cluster.go Outdated Show resolved Hide resolved
@hongtaiwang hongtaiwang force-pushed the enhance-output-command branch from 29100a7 to 8c1df7e Compare March 23, 2023 01:50
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4511/20230323015750/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Contributor

@wjun wjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wjun wjun added the ok-to-merge PRs should be labelled with this before merging label Mar 23, 2023
@hongtaiwang hongtaiwang merged commit e82d452 into main Mar 23, 2023
@hongtaiwang hongtaiwang deleted the enhance-output-command branch March 23, 2023 06:54
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants