Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Link VIB version to the build version. #613

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Conversation

kerneltime
Copy link
Contributor

The vib version was not being set for each build or release.
As per documentation an additional release version is added.

Versioning VIBs

Because VIBs are intended to allow the ESXi installer to handle updates as well as initial installs, it is
important to use the versioning variables in the VIB correctly.

The package version can have a length of up to 35 characters. It includes the version number, immediately
followed by a hyphen (‐) followed by the release version, as in the following example:

5.0.0-1.0vmw

Both the version number and the release version number consist of one or more characters in the set
[a‐a‐Z0‐9], with periods separating two or more groups.

Testing:

Make vib and install.

Run command esxcli software profile get

Output:

(Original Vendor):VMware, Inc.
      2016-07-06T10:45:12.595760+00:00: The following VIBs are
      installed:
        esx-vmdkops-service   0.7.14b2727-0.0.1

@msterin
Copy link
Contributor

msterin commented Oct 6, 2016

What's the output of /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py status ?

@kerneltime
Copy link
Contributor Author

[root@localhost:~]  /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py status
Version: 0.7.14b2727-0.0.1
Status: Running
Pid: 697796
Port: 1019
LogConfigFile: /etc/vmware/vmdkops/log_config.json
LogFile: /var/log/vmware/vmdk_ops.log
LogLevel: INFO

Copy link
Contributor

@msterin msterin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - only one nit about comment :-)

@@ -27,7 +27,14 @@ PYLINT := /usr/bin/pylint
BIN := ../build

# VIB version is either set from outside, or includes git commit SHA
PKG_VERSION ?= 0.1.TP-pre.$(shell git log --pretty=format:'%h' -n 1)
PKG_VERSION ?= $(shell \
Copy link
Contributor

@msterin msterin Oct 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would be nice to add a resulting format (example) to comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

The vib version was not being set for each build or release.
As per documentation an additional release version is added.

```
Versioning VIBs

Because VIBs are intended to allow the ESXi installer to handle updates as well as initial installs, it is
important to use the versioning variables in the VIB correctly.

The package version can have a length of up to 35 characters. It includes the version number, immediately
followed by a hyphen (‐) followed by the release version, as in the following example:

5.0.0-1.0vmw

Both the version number and the release version number consist of one or more characters in the set
[a‐a‐Z0‐9], with periods separating two or more groups.
```

Testing:

Make vib and install.

Run command ```esxcli software profile get```

Output:
```
(Original Vendor):VMware, Inc.
      2016-07-06T10:45:12.595760+00:00: The following VIBs are
      installed:
        esx-vmdkops-service   0.7.14b2727-0.0.1
```
@andrewjstone
Copy link
Contributor

LGTM

@kerneltime kerneltime merged commit 612581e into master Oct 6, 2016
@msterin msterin deleted the vibversions.kerneltime branch October 13, 2016 01:51
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants