Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Reorder ref count tests to ensure correct checks on count of volume users #826

Merged
merged 1 commit into from
Dec 20, 2016

Conversation

govint
Copy link
Contributor

@govint govint commented Dec 15, 2016

Had made these changes in PR #811, will submit via this PR instead as its not related to adding the photon driver.

Plus, the ref count test code is using plugin logs to figure out test result which doesn't work as expected always. These fixes ensure that the test result is deterministic.

Changes are:

  1. Got errors when creating the test volume that volume size is not specified - which happens as a result of a failing check in the auth code. Passing a size of 1GB for the test volume used.

  2. Moved the test for user count on the test volume (via check_files) to after the check on the users of the test volume. The test for user count itself runs a countainer to check the number of users of the ref count test volume and ends up increasing the volume user count. And the subsequent check (on user count) failed on occasion. Hence the reorder.

Test:

  1. Ran the ref count test manually and it works ok.
sudo ./build/docker-volume-vsphere.test
Running tests on  unix:///var/run/docker.sock (may take a while)...
Running parallel tests on unix:///var/run/docker.sock and unix:///var/run/docker.sock (may take a while)...
PASS

@govint
Copy link
Contributor Author

govint commented Dec 15, 2016

Fixes #790

@govint
Copy link
Contributor Author

govint commented Dec 19, 2016

Those issues I've addressed in this change that actually repro'ed during testing. Pls. review and let me know if its good to merge.

Copy link
Contributor

@pdhamdhere pdhamdhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msterin msterin merged commit 9620cd0 into master Dec 20, 2016
@govint govint deleted the ref-fix.govint branch December 23, 2016 07:47
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants