This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Reorder ref count tests to ensure correct checks on count of volume users #826
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had made these changes in PR #811, will submit via this PR instead as its not related to adding the photon driver.
Plus, the ref count test code is using plugin logs to figure out test result which doesn't work as expected always. These fixes ensure that the test result is deterministic.
Changes are:
Got errors when creating the test volume that volume size is not specified - which happens as a result of a failing check in the auth code. Passing a size of 1GB for the test volume used.
Moved the test for user count on the test volume (via check_files) to after the check on the users of the test volume. The test for user count itself runs a countainer to check the number of users of the ref count test volume and ends up increasing the volume user count. And the subsequent check (on user count) failed on occasion. Hence the reorder.
Test: