Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added Support for vrdma NIC Type #2766

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Added Support for vrdma NIC Type #2766

merged 1 commit into from
Mar 1, 2022

Conversation

cspnanda
Copy link

@cspnanda cspnanda commented Feb 19, 2022

Description

Add Support for
Closes: #2765

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Yes
VM Creation
Before:

govc vm.create -m 2048 -c 2 -g freebsd64Guest -net.adapter vmxnet3vrdma -net=Management -disk.controller pvscsi -ds=vsanDatastore -dc=Datacenter -cluster=Cluster vm-name
govc: unknown ethernet card type 'vmxnet3vrdma'

After:

./govc vm.create -m 2048 -c 2 -g freebsd64Guest -net.adapter vmxnet3vrdma -net=Management -disk.controller pvscsi -ds=vsanDatastore -dc=Datacenter -cluster=Cluster vm-name
echo $?
0

Checklist:

  • My code follows the CONTRIBUTION guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@vmwclabot
Copy link
Member

@cspnanda, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

Signed-off-by: C S P Nanda <cspnanda@gmail.com>
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cspnanda

@dougm dougm merged commit b780c8c into vmware:master Mar 1, 2022
@vmwclabot
Copy link
Member

@cspnanda, VMware has approved your signed contributor license agreement.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vRDMA Network Type Not Supported
4 participants