-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Task IAC-807] Enable Collecting Hints from vRO and Local Actions / Modules #144
[Task IAC-807] Enable Collecting Hints from vRO and Local Actions / Modules #144
Conversation
…g to generate actions.pb file
…l checks Signed-off-by: Alexander Kantchev <akantchev@vmware.com>"wq
@akantchev, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 54.21% 54.35% +0.13%
==========================================
Files 40 40
Lines 806 804 -2
Branches 117 116 -1
==========================================
Hits 437 437
+ Misses 331 330 -1
+ Partials 38 37 -1 |
@@ -134,6 +134,7 @@ export class ServerCollection { | |||
collectObjects() { | |||
this.getVroObjects() | |||
.then(objects => { | |||
// todo merge both in same actions.pb file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this todo for now and discuss it offline
@akantchev, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
@akantchev, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Description
When trying to invoke hinting for module System.getModule("module.path") or Class.load("class.path") it does not fetch the actions from the configured vRO instance and does not show any hints methods / actions for the module.
Checklist
Fixed #XXX -
orClosed #XXX -
prefix to auto-close the issueTesting
Open a java script action and try to write
or
or
It should be possible to fetch a list of modules (within the string literal) and actions / methods in the instance, that are displayed as lists. The class path can be either local or stored as an action in vRO.
Release Notes