Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Compatibility with recent versions of Noir and minor restructuring #2

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

ax0
Copy link
Contributor

@ax0 ax0 commented Jan 25, 2024

This PR brings the library in line with recent Noir versions (>=0.22.0), specifically:

  • The Nargo.toml file was modified, including a change of convention for the package name.
  • A bitwise & function for Field elements was added to helpers.nr and used in the function multiAnd.
  • Functions that specifically depend on the choice of field (BN254's scalar field in our case) have been marked with the #[field(bn254)] attribute.
  • The visibility of various functions have been specified. As it stands, only verify is marked pub.

In addition, the example provided in the README has been put in its own directory (example) and the project restructured as a workspace. The Go code generating test data and the README have been modified appropriately.

@p4u p4u requested a review from lucasmenendez January 25, 2024 08:32
@p4u
Copy link
Member

p4u commented Jan 25, 2024

please @lucasmenendez review

@lucasmenendez lucasmenendez merged commit 1453c4b into vocdoni:main Jan 25, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants