Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

<various>: Split "Firewalls" section into distinct sections. #508

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flexibeast
Copy link
Contributor

At request of @the-maldridge, to facilitate expanding content.

@ericonr: Does this look okay for me to merge?

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be too ugly to put the Firewall page inside network/index.md?

@flexibeast
Copy link
Contributor Author

@ericonr: Hmm, no, i don't think it would be .... Whereabouts would you suggest?

@flexibeast flexibeast force-pushed the split-firewalls-section branch 3 times, most recently from b64df05 to 793f79c Compare September 9, 2020 08:03
@flexibeast
Copy link
Contributor Author

@ericonr: i've added the contents of "Firewalls" to the end of network/index.md, and removed firewalls.md. Let me know if you think the content should go elsewhere on the page.

@flexibeast flexibeast force-pushed the split-firewalls-section branch from 793f79c to f901327 Compare September 9, 2020 08:07
@Duncaen
Copy link
Member

Duncaen commented Sep 9, 2020

Is this really worth it, is there that much content planned?

@flexibeast
Copy link
Contributor Author

@Duncaen: You'd have to ask @the-maldridge. :-)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants