Update theme, add light/dark mode switch #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classabbyamp
force-pushed
the
update
branch
3 times, most recently
from
c639ace to
e973189
Compare
classabbyamp
force-pushed
the
update
branch
3 times, most recently
from
373fa9d to
d16b3dd
Compare
|
This looks mostly ok to me :) Thanks for pushing it ahead! The print button sends me to https://void-book.qrm.cat/print.html and opens the print dialog for the About page, so there seems to be a bug there. |
|
Hm, that might be a limitation of the mdbook printing capability. I'll take a look into it |
|
can confirm. for example, this mdbook will go back to the first page when you press the print button. Also, it will print all pages, not just the first page (the about page in void-docs' case) |
classabbyamp
force-pushed
the
update
branch
2 times, most recently
from
1b0783e to
f43741b
Compare
classabbyamp
force-pushed
the
update
branch
2 times, most recently
from
124a174 to
0f47f0b
Compare
add buttons for printing, editing, and changing to dark theme clean up CSS, including improvements to the print theming Co-authored-by: Érico Nogueira <erico.erc@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off of @ericonr's WIP PR #581, and adds UI elements for printing and editing void-docs, as well as a
button to toggle between light and dark modes.
Examples of the updated version is live at https://void-book.qrm.cat
closes #581