Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use Playwright webServer option #58

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Use Playwright webServer option #58

merged 3 commits into from
Apr 12, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 12, 2023 •
edited
Loading

References

Use Playwright webServer option to start the web server automatically: https://playwright.dev/docs/test-configuration#launching-a-development-web-server-during-the-tests

Code changes

  • Playwright config update. This means we can remove the use of the ifaxity/wait-on-action@v1 GitHub Action.
  • Bump some GitHub Actions to remove Node.js 12 warnings

User-facing changes

None

Backwards-incompatible changes

None

@jtpio
Copy link
Member Author

jtpio commented Apr 12, 2023

Looking good on the report:

image

@jtpio jtpio marked this pull request as ready for review April 12, 2023 12:44
@trungleduc
Copy link
Member

Thanks @jtpio

@trungleduc trungleduc merged commit 7b8825e into voila-dashboards:main Apr 12, 2023
@jtpio jtpio deleted the playwright-webserver branch April 12, 2023 13:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @trungleduc