Wait for service worker on start up #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
trungleduc
changed the title
|
Curious what issue does this change fix? Was there some race conditions when a file would be read but the service worker would not be ready yet? |
|
I heuristically did this in the process of debugging the service worker problem. Before this change, the worker failed a lot for me, with this chance it feels better, I'm not entirely sure it would fix anything, but there is no harm in this logic so I decided to keep it. |
|
Do you have issues with this? |
No issues, just wanted to understand the motivation because the top comment of the PR was left empty. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Code changes
User-facing changes
Backwards-incompatible changes