Update ASCII.php for PHP 8.4 compatibility

[gilbertoalbino]

Fixes #

php 8.4 : Implicitly marking parameter $replace_single_chars_only as nullable is deprecated, the explicit nullable type must be used instead

Proposed Changes

Change NULL for FALSE and update the PHPDocs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[voku]

Thx for the fix. 👍

[TimWolla]

FWIW: This is a breaking change to the API. Explicitly passing null to the $replace_single_chars_only parameter will now result in a TypeError.

[phildawson-gravity]

I would agree with @TimWolla that changing to false is not the correct solution as it'll break those passing null.

It just needed to be marked as nullable with a question mark

?bool $replace_single_chars_only = null

[gilbertoalbino]

Hi @phildawson-gravity. This package is supposed to support PHP 7.0+.
Nullable types were added in PHP 7.1.

[phildawson-gravity]

@gilbertoalbino I hadn't appreciated that, I understand keeping support for the legacy 7.4, but 7.0 came out almost nine years ago and ended support five years ago.

Anyone passing null will just need to adapt to false to deal with it.

[gilbertoalbino]

@phildawson-gravity that anyone you mention does happen to just be Laravel until now, but they have done that.